2024-05-04 11:36:43

by Josua Mayer

[permalink] [raw]
Subject: [PATCH] arm64: dts: ti: k3-am642-hummingboard-t: correct rs485 rts polarity

The RS485 transceiver RE (Receiver enable) and DE (Driver enable) are
shorted and connected to both RTS/CTS of the SoC UART.
RE is active-low, DE is active-high.

Remove the "rs485-rts-active-low" flag to match RTS polarity with DE,
and fix communication in both transmit and receive directions.

Fixes: d60483faf914 ("arm64: dts: add description for solidrun am642 som and evaluation board")
Signed-off-by: Josua Mayer <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dts b/arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dts
index 234d76e4e944..5b5e9eeec5ac 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dts
@@ -282,7 +282,6 @@ &main_uart3 {
pinctrl-names = "default";
pinctrl-0 = <&main_uart3_default_pins>;
uart-has-rtscts;
- rs485-rts-active-low;
linux,rs485-enabled-at-boot-time;
status = "okay";
};

---
base-commit: 4cece764965020c22cff7665b18a012006359095
change-id: 20240504-ti-rs485-rts-e08a68eac841

Sincerely,
--
Josua Mayer <[email protected]>



2024-06-13 07:46:09

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ti: k3-am642-hummingboard-t: correct rs485 rts polarity

Hi Josua Mayer,

On Sat, 04 May 2024 13:35:54 +0200, Josua Mayer wrote:
> The RS485 transceiver RE (Receiver enable) and DE (Driver enable) are
> shorted and connected to both RTS/CTS of the SoC UART.
> RE is active-low, DE is active-high.
>
> Remove the "rs485-rts-active-low" flag to match RTS polarity with DE,
> and fix communication in both transmit and receive directions.
>
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-am642-hummingboard-t: correct rs485 rts polarity
commit: 9dcc0e1065f3c40d0b2ad79a858bb4ebaba33167

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh