2024-06-10 16:10:41

by Frank Li

[permalink] [raw]
Subject: [PATCH v3 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain

"fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Other
platform doesn't require 'power-domain'.

Signed-off-by: Frank Li <[email protected]>
---

Notes:
Change from v2 to v3
- only imx8qxp and imx8qm need power-domain, other platform don't need it.
- update commit message.

Change from v1 to v2
- set minitem to 2 at top
- Add imx8qm compatible string also
- use not logic to handle difference compatible string restriction
- update commit message.

pass dt_binding_check.

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,imx-rproc.yaml
SCHEMA Documentation/devicetree/bindings/processed-schema.json
CHKDT Documentation/devicetree/bindings
LINT Documentation/devicetree/bindings
DTEX Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dts
DTC_CHK Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dtb

.../bindings/remoteproc/fsl,imx-rproc.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
index df36e29d974ca..57d75acb0b5e5 100644
--- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
@@ -59,6 +59,7 @@ properties:
maxItems: 32

power-domains:
+ minItems: 2
maxItems: 8

fsl,auto-boot:
@@ -99,6 +100,20 @@ allOf:
properties:
fsl,iomuxc-gpr: false

+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx8qxp-cm4
+ - fsl,imx8qm-cm4
+ then:
+ required:
+ - power-domains
+ else:
+ properties:
+ power-domains: false
+
additionalProperties: false

examples:
--
2.34.1



2024-06-13 16:54:52

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain


On Mon, 10 Jun 2024 11:17:21 -0400, Frank Li wrote:
> "fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Other
> platform doesn't require 'power-domain'.
>
> Signed-off-by: Frank Li <[email protected]>
> ---
>
> Notes:
> Change from v2 to v3
> - only imx8qxp and imx8qm need power-domain, other platform don't need it.
> - update commit message.
>
> Change from v1 to v2
> - set minitem to 2 at top
> - Add imx8qm compatible string also
> - use not logic to handle difference compatible string restriction
> - update commit message.
>
> pass dt_binding_check.
>
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,imx-rproc.yaml
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> CHKDT Documentation/devicetree/bindings
> LINT Documentation/devicetree/bindings
> DTEX Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dts
> DTC_CHK Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dtb
>
> .../bindings/remoteproc/fsl,imx-rproc.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>

Reviewed-by: Rob Herring (Arm) <[email protected]>