On 20.01.21 14:27, Mohamed Mediouni wrote:
> From: Stan Skowronek <[email protected]>
>
> Apple SoCs use the Apple AIC interrupt controller.
> The Arm architectural timers is wired over FIQ on that hardware.
>
> Signed-off-by: Stan Skowronek <[email protected]>
> Signed-off-by: Mohamed Mediouni <[email protected]>
> ---
> .../interrupt-controller/apple,aic.yaml | 49 ++++
> MAINTAINERS | 6 +
> drivers/irqchip/Kconfig | 6 +
> drivers/irqchip/Makefile | 1 +
> drivers/irqchip/irq-apple-aic.c | 211 ++++++++++++++++++
> 5 files changed, 273 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> create mode 100644 drivers/irqchip/irq-apple-aic.c
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> new file mode 100644
> index 000000000000..e615eaaca869
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/apple,aic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple Advanced Interrupt Controller (AIC)
> +
> +description:
> + Interrupt controller present on Apple processors. AIC
> + is used by Apple on their AArch64 SoCs since the Apple A7.
> +
> +maintainers:
> + - Stan Skowronek <[email protected]>
> +
> +properties:
> + compatible:
> + items:
> + - const: apple,aic
> +
> + reg:
> + maxItems: 1
> +
> + '#interrupt-cells':
> + const: 3
> +
> + interrupt-controller: true
> +
> + fast-ipi:
> + description:
> + Fast IPI support.
> +
> +required:
> + - compatible
> + - '#interrupt-cells'
> + - interrupt-controller
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + aic: interrupt-controller@23b100000 {
> + compatible = "apple,aic";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0x2 0x3b100000 0x0 0x8000>;
> + fast-ipi;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 00836f6452f0..e609ede99dd4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1218,6 +1218,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor
> F: Documentation/admin-guide/LSM/apparmor.rst
> F: security/apparmor/
>
> +APPLE ADVANCED INTERRUPT CONTROLLER DRIVER
> +M: Stan Skowronek <[email protected]>
Signing someone else up for maintainership is ... unusual :). Do you
have buy in from Stan that he'll be responsive and handle patch reviews?
> +L: [email protected]
> +S: Maintained
> +F: drivers/irqchip/irq-apple-aic.c
> +
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
> On 20 Jan 2021, at 18:11, Alexander Graf <[email protected]> wrote:
>
> On 20.01.21 14:27, Mohamed Mediouni wrote:
>> From: Stan Skowronek <[email protected]>
>> Apple SoCs use the Apple AIC interrupt controller.
>> The Arm architectural timers is wired over FIQ on that hardware.
>> Signed-off-by: Stan Skowronek <[email protected]>
>> Signed-off-by: Mohamed Mediouni <[email protected]>
>> ---
>> .../interrupt-controller/apple,aic.yaml | 49 ++++
>> MAINTAINERS | 6 +
>> drivers/irqchip/Kconfig | 6 +
>> drivers/irqchip/Makefile | 1 +
>> drivers/irqchip/irq-apple-aic.c | 211 ++++++++++++++++++
>> 5 files changed, 273 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
>> create mode 100644 drivers/irqchip/irq-apple-aic.c
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
>> new file mode 100644
>> index 000000000000..e615eaaca869
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
>> @@ -0,0 +1,49 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/interrupt-controller/apple,aic.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Apple Advanced Interrupt Controller (AIC)
>> +
>> +description:
>> + Interrupt controller present on Apple processors. AIC
>> + is used by Apple on their AArch64 SoCs since the Apple A7.
>> +
>> +maintainers:
>> + - Stan Skowronek <[email protected]>
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: apple,aic
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + '#interrupt-cells':
>> + const: 3
>> +
>> + interrupt-controller: true
>> +
>> + fast-ipi:
>> + description:
>> + Fast IPI support.
>> +
>> +required:
>> + - compatible
>> + - '#interrupt-cells'
>> + - interrupt-controller
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + aic: interrupt-controller@23b100000 {
>> + compatible = "apple,aic";
>> + #interrupt-cells = <3>;
>> + interrupt-controller;
>> + reg = <0x2 0x3b100000 0x0 0x8000>;
>> + fast-ipi;
>> + };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 00836f6452f0..e609ede99dd4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1218,6 +1218,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor
>> F: Documentation/admin-guide/LSM/apparmor.rst
>> F: security/apparmor/
>> +APPLE ADVANCED INTERRUPT CONTROLLER DRIVER
>> +M: Stan Skowronek <[email protected]>
>
> Signing someone else up for maintainership is ... unusual :). Do you have buy in from Stan that he'll be responsive and handle patch reviews?
Yeah, I asked Corellium about it explicitly. :)
>> +L: [email protected]
>> +S: Maintained
>> +F: drivers/irqchip/irq-apple-aic.c
>> +
>
>
> Alex
>
>
>
> Amazon Development Center Germany GmbH
> Krausenstr. 38
> 10117 Berlin
> Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
> Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
> Sitz: Berlin
> Ust-ID: DE 289 237 879
> >> @@ -1218,6 +1218,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor
> >> F: Documentation/admin-guide/LSM/apparmor.rst
> >> F: security/apparmor/
> >> +APPLE ADVANCED INTERRUPT CONTROLLER DRIVER
> >> +M: Stan Skowronek <[email protected]>
> >
> > Signing someone else up for maintainership is ... unusual :). Do you have buy in from Stan that he'll be responsive and handle patch reviews?
>
> Yeah, I asked Corellium about it explicitly. :)
Having an Ack-by: from Stan Skowronek would remove all doubt.
Andrew