2020-04-03 14:00:29

by Angelo Ribeiro

Subject: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file

dw-mipi-dsi does not use any definition from drm_probe_helper.

Coverity output:
Event unnecessary_header:
Including .../include/drm/drm_probe_helper.h does not provide any
needed symbols.

Cc: Gustavo Pimentel <[email protected]>
Cc: Joao Pinto <[email protected]>
Cc: Jose Abreu <[email protected]>
Signed-off-by: Angelo Ribeiro <[email protected]>
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 024acad..582635d 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -27,7 +27,6 @@
#include <drm/drm_modes.h>
#include <drm/drm_of.h>
#include <drm/drm_print.h>
-#include <drm/drm_probe_helper.h>

#define HWVER_131 0x31333100 /* IP version 1.31 */

--
2.7.4

2020-06-24 15:09:45

by Yannick FERTRE

Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file

Hello Angelo,
thank for patch.

Reviewed-by: Yannick Fertre <[email protected]>



On 4/3/20 3:30 PM, Angelo Ribeiro wrote:
> dw-mipi-dsi does not use any definition from drm_probe_helper.
>
> Coverity output:
> Event unnecessary_header:
> Including .../include/drm/drm_probe_helper.h does not provide any
> needed symbols.
>
> Cc: Gustavo Pimentel <[email protected]>
> Cc: Joao Pinto <[email protected]>
> Cc: Jose Abreu <[email protected]>
> Signed-off-by: Angelo Ribeiro <[email protected]>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 024acad..582635d 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -27,7 +27,6 @@
> #include <drm/drm_modes.h>
> #include <drm/drm_of.h>
> #include <drm/drm_print.h>
> -#include <drm/drm_probe_helper.h>
>
> #define HWVER_131 0x31333100 /* IP version 1.31 */
>
>

2020-06-25 07:55:01

by Daniel Vetter

Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file

On Wed, Jun 24, 2020 at 03:08:22PM +0000, Yannick FERTRE wrote:
> Hello Angelo,
> thank for patch.
>
> Reviewed-by: Yannick Fertre <[email protected]>

Patch applied, thanks.
-Daniel

>
>
>
> On 4/3/20 3:30 PM, Angelo Ribeiro wrote:
> > dw-mipi-dsi does not use any definition from drm_probe_helper.
> >
> > Coverity output:
> > Event unnecessary_header:
> > Including .../include/drm/drm_probe_helper.h does not provide any
> > needed symbols.
> >
> > Cc: Gustavo Pimentel <[email protected]>
> > Cc: Joao Pinto <[email protected]>
> > Cc: Jose Abreu <[email protected]>
> > Signed-off-by: Angelo Ribeiro <[email protected]>
> > ---
> > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > index 024acad..582635d 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> > @@ -27,7 +27,6 @@
> > #include <drm/drm_modes.h>
> > #include <drm/drm_of.h>
> > #include <drm/drm_print.h>
> > -#include <drm/drm_probe_helper.h>
> >
> > #define HWVER_131 0x31333100 /* IP version 1.31 */
> >
> >

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch