2018-05-05 20:38:30

by Mathieu Malaterre

Subject: [PATCH] acpi: add missing prototype for ‘arch_post_acpi_subsys_init’

In commit e7ff3a47630d ("x86/amd: Check for the C1E bug post ACPI subsystem
init") a new function ‘arch_post_acpi_subsys_init’ was introduced. This
weak function can potentially be overridden on a per arch basis, introduce
the prototype for clarity.

Silence the following gcc warning (W=1):

init/main.c:484:20: warning: no previous prototype for ‘arch_post_acpi_subsys_init’ [-Wmissing-prototypes]

Signed-off-by: Mathieu Malaterre <[email protected]>
---
include/linux/acpi.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 15bfb15c2fa5..cb4d7b6b085c 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -578,6 +578,7 @@ int acpi_match_platform_list(const struct acpi_platform_list *plat);

extern void acpi_early_init(void);
extern void acpi_subsystem_init(void);
+extern void arch_post_acpi_subsys_init(void);

extern int acpi_nvs_register(__u64 start, __u64 size);

--
2.11.0

2018-05-17 10:16:57

by Rafael J. Wysocki

Subject: Re: [PATCH] acpi: add missing prototype for ‘arch_post_acpi_subsys_init’

On Saturday, May 5, 2018 10:36:03 PM CEST Mathieu Malaterre wrote:
> In commit e7ff3a47630d ("x86/amd: Check for the C1E bug post ACPI subsystem
> init") a new function ‘arch_post_acpi_subsys_init’ was introduced. This
> weak function can potentially be overridden on a per arch basis, introduce
> the prototype for clarity.
>
> Silence the following gcc warning (W=1):
>
> init/main.c:484:20: warning: no previous prototype for ‘arch_post_acpi_subsys_init’ [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <[email protected]>
> ---
> include/linux/acpi.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 15bfb15c2fa5..cb4d7b6b085c 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -578,6 +578,7 @@ int acpi_match_platform_list(const struct acpi_platform_list *plat);
>
> extern void acpi_early_init(void);
> extern void acpi_subsystem_init(void);
> +extern void arch_post_acpi_subsys_init(void);
>
> extern int acpi_nvs_register(__u64 start, __u64 size);
>
>

Applied, thanks!