2014-01-10 06:03:11

by Neil Zhang

Subject: [PATCH] gpio: pxa: normalize the return value for gpio_get

It would be convenient to normalize the return value for gpio_get.

I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x.
It's OK for all of them to change this function to return 0 and 1.

Signed-off-by: Neil Zhang <[email protected]>
---
drivers/gpio/gpio-pxa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index cc13d1b..42e6e64 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -263,7 +263,8 @@ static int pxa_gpio_direction_output(struct gpio_chip *chip,

static int pxa_gpio_get(struct gpio_chip *chip, unsigned offset)
{
- return readl_relaxed(gpio_chip_base(chip) + GPLR_OFFSET) & (1 << offset);
+ u32 gplr = readl_relaxed(gpio_chip_base(chip) + GPLR_OFFSET);
+ return !!(gplr & (1 << offset));
}

static void pxa_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
--
1.7.9.5

2014-01-15 07:57:57

by Linus Walleij

Subject: Re: [PATCH] gpio: pxa: normalize the return value for gpio_get

On Fri, Jan 10, 2014 at 7:03 AM, Neil Zhang <[email protected]> wrote:

> It would be convenient to normalize the return value for gpio_get.
>
> I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x.
> It's OK for all of them to change this function to return 0 and 1.
>
> Signed-off-by: Neil Zhang <[email protected]>

Bah I updated the commit message a bit ... you dropped the
gpio: pxa: etc from the previous patch, not good but don't worry
I fixed it up.

Yours,
Linus Walleij

2014-01-15 08:26:50

by Neil Zhang

Subject: RE: [PATCH] gpio: pxa: normalize the return value for gpio_get

> -----Original Message-----
> From: Linus Walleij [mailto:[email protected]]
> Sent: 2014??1??15?? 15:58
> To: Neil Zhang
> Cc: Alexandre Courbot; [email protected]; [email protected]
> Subject: Re: [PATCH] gpio: pxa: normalize the return value for gpio_get
>
> On Fri, Jan 10, 2014 at 7:03 AM, Neil Zhang <[email protected]> wrote:
>
> > It would be convenient to normalize the return value for gpio_get.
> >
> > I have checked mach-mmp / mach-pxa / plat-pxa / plat-orion / mach-orion5x.
> > It's OK for all of them to change this function to return 0 and 1.
> >
> > Signed-off-by: Neil Zhang <[email protected]>
>
> Bah I updated the commit message a bit ... you dropped the
> gpio: pxa: etc from the previous patch, not good but don't worry I fixed it up.
>
Thanks!

> Yours,
> Linus Walleij

Best Regards,
Neil Zhang
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?