2013-03-16 04:21:37

by Axel Lin

Subject: [PATCH RESEND] gpio: samsung: Add terminating entry for exynos_pinctrl_ids

The of_device_id table is supposed to be zero-terminated.

Signed-off-by: Axel Lin <[email protected]>
Acked-by: Grant Likely <[email protected]>
---
This patch was sent on https://lkml.org/lkml/2012/12/9/135
Re-generate the patch against linux-next and resend.

drivers/gpio/gpio-samsung.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
index 99e0fa4..b22ca79 100644
--- a/drivers/gpio/gpio-samsung.c
+++ b/drivers/gpio/gpio-samsung.c
@@ -3030,6 +3030,7 @@ static __init int samsung_gpiolib_init(void)
{ .compatible = "samsung,exynos4x12-pinctrl", },
{ .compatible = "samsung,exynos5250-pinctrl", },
{ .compatible = "samsung,exynos5440-pinctrl", },
+ { }
};
for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
if (pctrl_np && of_device_is_available(pctrl_np))
--
1.7.9.5

2013-03-25 10:16:47

by Kukjin Kim

Subject: RE: [PATCH RESEND] gpio: samsung: Add terminating entry for exynos_pinctrl_ids

Axel Lin wrote:
>
> The of_device_id table is supposed to be zero-terminated.
>
> Signed-off-by: Axel Lin <[email protected]>
> Acked-by: Grant Likely <[email protected]>

Acked-by: Kukjin Kim <[email protected]>

I think, would be better if this could be sent to upstream via gpio tree now.

Thanks.

- Kukjin

> ---
> This patch was sent on https://lkml.org/lkml/2012/12/9/135
> Re-generate the patch against linux-next and resend.
>
> drivers/gpio/gpio-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 99e0fa4..b22ca79 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -3030,6 +3030,7 @@ static __init int samsung_gpiolib_init(void)
> { .compatible = "samsung,exynos4x12-pinctrl", },
> { .compatible = "samsung,exynos5250-pinctrl", },
> { .compatible = "samsung,exynos5440-pinctrl", },
> + { }
> };
> for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
> if (pctrl_np && of_device_is_available(pctrl_np))
> --
> 1.7.9.5

2013-03-27 14:04:17

by Linus Walleij

Subject: Re: [PATCH RESEND] gpio: samsung: Add terminating entry for exynos_pinctrl_ids

On Sat, Mar 16, 2013 at 5:21 AM, Axel Lin <[email protected]> wrote:

> The of_device_id table is supposed to be zero-terminated.
>
> Signed-off-by: Axel Lin <[email protected]>
> Acked-by: Grant Likely <[email protected]>

Patch applied with Kukjin's ACK.

Thanks!
Linus Walleij