2014-02-19 23:34:35

by Daeseok Youn

Subject: [PATCH v2] ata: libahci: make ahci_pmp_retry_softreset() as static

>From 6f865fde2e48ddc09f940ec30ebfc144cf074fd1 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 10:56:37 +0900
Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static

sparse says:

drivers/ata/libahci.c:1390:5: warning:
symbol 'ahci_pmp_retry_softreset' was not declared. Should it be static?

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/ata/libahci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 36605ab..4789950 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1387,8 +1387,8 @@ static int ahci_bad_pmp_check_ready(struct ata_link *link)
return ata_check_ready(status);
}

-int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class,
- unsigned long deadline)
+static int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class,
+ unsigned long deadline)
{
struct ata_port *ap = link->ap;
void __iomem *port_mmio = ahci_port_base(ap);
--
1.7.9.5

---

2014-02-20 00:09:11

by Tejun Heo

Subject: Re: [PATCH v2] ata: libahci: make ahci_pmp_retry_softreset() as static

On Thu, Feb 20, 2014 at 08:34:27AM +0900, Daeseok Youn wrote:
> From 6f865fde2e48ddc09f940ec30ebfc144cf074fd1 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Wed, 19 Feb 2014 10:56:37 +0900
> Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static
>
> sparse says:
>
> drivers/ata/libahci.c:1390:5: warning:
> symbol 'ahci_pmp_retry_softreset' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <[email protected]>

Applied to libata/for-3.15.

Thanks.

--
tejun