2019-10-15 14:10:24

by Ben Dooks

Subject: [PATCH] soc: imx: gpc: fix initialiser format

Make the initialiers in imx_gpc_domains C99 format to fix the
following sparse warnings:

drivers/soc/imx/gpc.c:252:30: warning: obsolete array initializer, use C99 syntax
drivers/soc/imx/gpc.c:258:29: warning: obsolete array initializer, use C99 syntax
drivers/soc/imx/gpc.c:269:34: warning: obsolete array initializer, use C99 syntax
drivers/soc/imx/gpc.c:278:30: warning: obsolete array initializer, use C99 syntax

Signed-off-by: Ben Dooks <[email protected]>
---
Cc: Shawn Guo <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/soc/imx/gpc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
index d9231bd3c691..98b9d9a902ae 100644
--- a/drivers/soc/imx/gpc.c
+++ b/drivers/soc/imx/gpc.c
@@ -249,13 +249,13 @@ static struct genpd_power_state imx6_pm_domain_pu_state = {
};

static struct imx_pm_domain imx_gpc_domains[] = {
- [GPC_PGC_DOMAIN_ARM] {
+ [GPC_PGC_DOMAIN_ARM] = {
.base = {
.name = "ARM",
.flags = GENPD_FLAG_ALWAYS_ON,
},
},
- [GPC_PGC_DOMAIN_PU] {
+ [GPC_PGC_DOMAIN_PU] = {
.base = {
.name = "PU",
.power_off = imx6_pm_domain_power_off,
@@ -266,7 +266,7 @@ static struct imx_pm_domain imx_gpc_domains[] = {
.reg_offs = 0x260,
.cntr_pdn_bit = 0,
},
- [GPC_PGC_DOMAIN_DISPLAY] {
+ [GPC_PGC_DOMAIN_DISPLAY] = {
.base = {
.name = "DISPLAY",
.power_off = imx6_pm_domain_power_off,
@@ -275,7 +275,7 @@ static struct imx_pm_domain imx_gpc_domains[] = {
.reg_offs = 0x240,
.cntr_pdn_bit = 4,
},
- [GPC_PGC_DOMAIN_PCI] {
+ [GPC_PGC_DOMAIN_PCI] = {
.base = {
.name = "PCI",
.power_off = imx6_pm_domain_power_off,
--
2.23.0

2019-10-15 14:11:59

by Lucas Stach

Subject: Re: [PATCH] soc: imx: gpc: fix initialiser format

On Di, 2019-10-15 at 15:09 +0100, Ben Dooks wrote:
> Make the initialiers in imx_gpc_domains C99 format to fix the
> following sparse warnings:
>
> drivers/soc/imx/gpc.c:252:30: warning: obsolete array initializer, use C99 syntax
> drivers/soc/imx/gpc.c:258:29: warning: obsolete array initializer, use C99 syntax
> drivers/soc/imx/gpc.c:269:34: warning: obsolete array initializer, use C99 syntax
> drivers/soc/imx/gpc.c:278:30: warning: obsolete array initializer, use C99 syntax
>
> Signed-off-by: Ben Dooks <[email protected]>

Reviewed-by: Lucas Stach <[email protected]>

> ---
> Cc: Shawn Guo <[email protected]>
> Cc: Sascha Hauer <[email protected]>
> Cc: Pengutronix Kernel Team <[email protected]>
> Cc: Fabio Estevam <[email protected]>
> Cc: NXP Linux Team <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> drivers/soc/imx/gpc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index d9231bd3c691..98b9d9a902ae 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -249,13 +249,13 @@ static struct genpd_power_state imx6_pm_domain_pu_state = {
> };
>
> static struct imx_pm_domain imx_gpc_domains[] = {
> - [GPC_PGC_DOMAIN_ARM] {
> + [GPC_PGC_DOMAIN_ARM] = {
> .base = {
> .name = "ARM",
> .flags = GENPD_FLAG_ALWAYS_ON,
> },
> },
> - [GPC_PGC_DOMAIN_PU] {
> + [GPC_PGC_DOMAIN_PU] = {
> .base = {
> .name = "PU",
> .power_off = imx6_pm_domain_power_off,
> @@ -266,7 +266,7 @@ static struct imx_pm_domain imx_gpc_domains[] = {
> .reg_offs = 0x260,
> .cntr_pdn_bit = 0,
> },
> - [GPC_PGC_DOMAIN_DISPLAY] {
> + [GPC_PGC_DOMAIN_DISPLAY] = {
> .base = {
> .name = "DISPLAY",
> .power_off = imx6_pm_domain_power_off,
> @@ -275,7 +275,7 @@ static struct imx_pm_domain imx_gpc_domains[] = {
> .reg_offs = 0x240,
> .cntr_pdn_bit = 4,
> },
> - [GPC_PGC_DOMAIN_PCI] {
> + [GPC_PGC_DOMAIN_PCI] = {
> .base = {
> .name = "PCI",
> .power_off = imx6_pm_domain_power_off,

2019-10-26 11:51:43

by Shawn Guo

Subject: Re: [PATCH] soc: imx: gpc: fix initialiser format

On Tue, Oct 15, 2019 at 03:09:09PM +0100, Ben Dooks wrote:
> Make the initialiers in imx_gpc_domains C99 format to fix the
> following sparse warnings:
>
> drivers/soc/imx/gpc.c:252:30: warning: obsolete array initializer, use C99 syntax
> drivers/soc/imx/gpc.c:258:29: warning: obsolete array initializer, use C99 syntax
> drivers/soc/imx/gpc.c:269:34: warning: obsolete array initializer, use C99 syntax
> drivers/soc/imx/gpc.c:278:30: warning: obsolete array initializer, use C99 syntax
>
> Signed-off-by: Ben Dooks <[email protected]>

Applied, thanks.