2014-10-25 18:52:29

by Alexander Stein

[permalink] [raw]
Subject: [PATCH 1/1] W1: ds2490: Increase timeout when waiting for status

Adjust the bulk message timeout to the other ones (1000ms). Otherwise the
following dmesg errors can be seen on a Raspberry Pi:
[ 31.492386] Failed to read 1-wire data from 0x81: err=-110.
[ 31.504168] 0x81: count=-110, status:
[ 31.613404] Failed to read 1-wire data from 0x81: err=-110.
[ 31.621915] 0x81: count=-110, status:
[ 43.260968] Failed to read 1-wire data from 0x81: err=-110.
[ 43.270998] 0x81: count=-110, status:
[ 43.379959] Failed to read 1-wire data from 0x81: err=-110.
[ 43.388854] 0x81: count=-110, status:

Signed-off-by: Alexander Stein <[email protected]>
---
drivers/w1/masters/ds2490.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
index 1de6df8..049a884 100644
--- a/drivers/w1/masters/ds2490.c
+++ b/drivers/w1/masters/ds2490.c
@@ -253,7 +253,7 @@ static int ds_recv_status_nodump(struct ds_device *dev, struct ds_status *st,

count = 0;
err = usb_interrupt_msg(dev->udev, usb_rcvintpipe(dev->udev,
- dev->ep[EP_STATUS]), buf, size, &count, 100);
+ dev->ep[EP_STATUS]), buf, size, &count, 1000);
if (err < 0) {
pr_err("Failed to read 1-wire data from 0x%x: err=%d.\n",
dev->ep[EP_STATUS], err);
--
2.1.2


2014-10-25 20:58:09

by Evgeniy Polyakov

[permalink] [raw]
Subject: Re: [PATCH 1/1] W1: ds2490: Increase timeout when waiting for status

Hi everyone

This looks good to me
Greg, please pull it into your tree

Thank you

25.10.2014, 16:27, "Alexander Stein" <[email protected]>:
> Adjust the bulk message timeout to the other ones (1000ms). Otherwise the
> following dmesg errors can be seen on a Raspberry Pi:
> [ ??31.492386] Failed to read 1-wire data from 0x81: err=-110.
> [ ??31.504168] 0x81: count=-110, status:
> [ ??31.613404] Failed to read 1-wire data from 0x81: err=-110.
> [ ??31.621915] 0x81: count=-110, status:
> [ ??43.260968] Failed to read 1-wire data from 0x81: err=-110.
> [ ??43.270998] 0x81: count=-110, status:
> [ ??43.379959] Failed to read 1-wire data from 0x81: err=-110.
> [ ??43.388854] 0x81: count=-110, status:
>
> Signed-off-by: Alexander Stein <[email protected]>

Acked-by: Evgeniy Polyakov <[email protected]>