2022-04-20 20:31:03

by Keoseong Park

[permalink] [raw]
Subject: RE: [PATCH v2 2/5] scsi: ufshpb: Remove 0 assignment for enum value

>From: Bean Huo <[email protected]>
>
>If the first enumerator has no initializer, the value of the corresponding
>constant is zero.
>
>Signed-off-by: Bean Huo <[email protected]>
>---
> drivers/scsi/ufs/ufshpb.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
>index 2825ec69a6a6..b7e2817d4e76 100644
>--- a/drivers/scsi/ufs/ufshpb.h
>+++ b/drivers/scsi/ufs/ufshpb.h
>@@ -59,8 +59,8 @@ enum UFSHPB_MODE {
> };
>
> enum UFSHPB_STATE {
>- HPB_INIT = 0,
>- HPB_PRESENT = 1,
>+ HPB_INIT,
>+ HPB_PRESENT,
> HPB_SUSPEND,
> HPB_FAILED,
> HPB_RESET,
>--
>2.34.1
>

Reviewed-by: Keoseong Park <[email protected]>

Best Regards,
Keoseong Park