2023-12-23 16:23:30

by Abdel Alkuor

[permalink] [raw]
Subject: [PATCH v4 1/2] dt-bindings: hwmon: (lm75) Add AMS AS6200 temperature sensor

as6200 is a temperature sensor with a range between -40°C to
125°C degrees and an accuracy of ±0.4°C degree between 0
and 65°C and ±1°C for the other ranges.

Signed-off-by: Abdel Alkuor <[email protected]>
---
Changes in v4:
- Add chips that support interrupt
Changes in v3:
- Enable interrupt property conditionally based on the chips that
support it.
- Fix alignment for the added example
Changes in v2:
- Incorporate as6200 into lm75 bindings

.../devicetree/bindings/hwmon/lm75.yaml | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/lm75.yaml b/Documentation/devicetree/bindings/hwmon/lm75.yaml
index 0b69897f0c63..ed269e428a3d 100644
--- a/Documentation/devicetree/bindings/hwmon/lm75.yaml
+++ b/Documentation/devicetree/bindings/hwmon/lm75.yaml
@@ -14,6 +14,7 @@ properties:
compatible:
enum:
- adi,adt75
+ - ams,as6200
- atmel,at30ts74
- dallas,ds1775
- dallas,ds75
@@ -48,10 +49,28 @@ properties:
vs-supply:
description: phandle to the regulator that provides the +VS supply

+ interrupts:
+ maxItems: 1
+
required:
- compatible
- reg

+allOf:
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - ams,as6200
+ - ti,tmp100
+ - ti,tmp101
+ - ti,tmp112
+ then:
+ properties:
+ interrupts: false
+
additionalProperties: false

examples:
@@ -66,3 +85,17 @@ examples:
vs-supply = <&vs>;
};
};
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ temperature-sensor@48 {
+ compatible = "ams,as6200";
+ reg = <0x48>;
+ vs-supply = <&vs>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <17 IRQ_TYPE_EDGE_BOTH>;
+ };
+ };
--
2.34.1



2023-12-24 09:32:56

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: (lm75) Add AMS AS6200 temperature sensor

On 23/12/2023 17:21, Abdel Alkuor wrote:
> as6200 is a temperature sensor with a range between -40°C to
> 125°C degrees and an accuracy of ±0.4°C degree between 0
> and 65°C and ±1°C for the other ranges.
>
> Signed-off-by: Abdel Alkuor <[email protected]>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2023-12-31 18:12:27

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: (lm75) Add AMS AS6200 temperature sensor

On Sat, Dec 23, 2023 at 11:21:58AM -0500, Abdel Alkuor wrote:
> as6200 is a temperature sensor with a range between -40?C to
> 125?C degrees and an accuracy of ?0.4?C degree between 0
> and 65?C and ?1?C for the other ranges.
>
> Signed-off-by: Abdel Alkuor <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Applied.

Thanks,
Guenter