2018-09-11 07:00:48

by Gerd Hoffmann

Subject: [PATCH 10/10] udmabuf: use ENOTTY for invalid ioctls

Reported-by: Laurent Pinchart <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
---
drivers/dma-buf/udmabuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index 1862bb6bed..a543fd6ea1 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -260,7 +260,7 @@ static long udmabuf_ioctl(struct file *filp, unsigned int ioctl,
ret = udmabuf_ioctl_create_list(filp, arg);
break;
default:
- ret = -EINVAL;
+ ret = -ENOTTY;
break;
}
return ret;
--
2.9.3

2018-09-11 09:43:44

by Laurent Pinchart

Subject: Re: [PATCH 10/10] udmabuf: use ENOTTY for invalid ioctls

Hi Gerd,

Thank you for the patch.

On Tuesday, 11 September 2018 09:59:21 EEST Gerd Hoffmann wrote:
> Reported-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Gerd Hoffmann <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/dma-buf/udmabuf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index 1862bb6bed..a543fd6ea1 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -260,7 +260,7 @@ static long udmabuf_ioctl(struct file *filp, unsigned
> int ioctl, ret = udmabuf_ioctl_create_list(filp, arg);
> break;
> default:
> - ret = -EINVAL;
> + ret = -ENOTTY;
> break;
> }
> return ret;

--
Regards,

Laurent Pinchart