2022-08-30 15:37:26

by Elijah Conners

Subject: [PATCH] iocost_monitor: reorder BlkgIterator

In order to comply with PEP 8, the first parameter of a class should be
__init__.

Signed-off-by: Elijah Conners <[email protected]>
---
tools/cgroup/iocost_monitor.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/cgroup/iocost_monitor.py b/tools/cgroup/iocost_monitor.py
index c4ff907c078b..0dbbc67400fc 100644
--- a/tools/cgroup/iocost_monitor.py
+++ b/tools/cgroup/iocost_monitor.py
@@ -61,6 +61,11 @@ autop_names = {
}

class BlkgIterator:
+ def __init__(self, root_blkcg, q_id, include_dying=False):
+ self.include_dying = include_dying
+ self.blkgs = []
+ self.walk(root_blkcg, q_id, '')
+
def blkcg_name(blkcg):
return blkcg.css.cgroup.kn.name.string_().decode('utf-8')

@@ -82,11 +87,6 @@ class BlkgIterator:
blkcg.css.children.address_of_(), 'css.sibling'):
self.walk(c, q_id, path)

- def __init__(self, root_blkcg, q_id, include_dying=False):
- self.include_dying = include_dying
- self.blkgs = []
- self.walk(root_blkcg, q_id, '')
-
def __iter__(self):
return iter(self.blkgs)

--
2.25.1

2022-09-24 03:11:07

by Tejun Heo

Subject: Re: [PATCH] iocost_monitor: reorder BlkgIterator

On Tue, Aug 30, 2022 at 07:38:27AM -0700, Elijah Conners wrote:
> In order to comply with PEP 8, the first parameter of a class should be
> __init__.
>
> Signed-off-by: Elijah Conners <[email protected]>

Applied to cgroup/for-6.1.

Thanks.

--
tejun