Hi,
I've rebased this series on linux-next. Patch [1/3] of this series is
already applied but I'm resending it just to avoid Bot errors.
Thanks,
Satya Priya
satya priya (3):
dt-bindings: mfd: pm8008: Add gpio-ranges and spmi-gpio compatible
dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings
to YAML
dt-bindings: pinctrl: qcom-pmic-gpio: Remove the interrupts property
.../devicetree/bindings/mfd/qcom,pm8008.yaml | 13 +-
.../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 290 ---------------------
.../bindings/pinctrl/qcom,pmic-gpio.yaml | 239 +++++++++++++++++
3 files changed, 249 insertions(+), 293 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Remove the interrupts property as we no longer specify it.
Signed-off-by: satya priya <[email protected]>
Acked-by: Rob Herring <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
---
Changes in V5:
- This is newly added in V5.As per Bjorn's comments on [1]
removed the interrupts property as it is no longer used.
[1] https://lore.kernel.org/patchwork/patch/1434144/
Changes in V6:
- No changes.
Changes in V7:
- No changes.
Changes in RESEND V7:
- Rebased on linux-next.
.../bindings/pinctrl/qcom,pmic-gpio.yaml | 28 ++++------------------
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 7a0d2d8..9bd01db 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -56,18 +56,11 @@ properties:
reg:
maxItems: 1
- interrupts:
- minItems: 1
- maxItems: 44
- description:
- Must contain an array of encoded interrupt specifiers for
- each available GPIO
+ interrupt-controller: true
'#interrupt-cells':
const: 2
- interrupt-controller: true
-
gpio-controller: true
gpio-ranges:
@@ -87,6 +80,7 @@ required:
- gpio-controller
- '#gpio-cells'
- gpio-ranges
+ - interrupt-controller
patternProperties:
'-state$':
@@ -223,22 +217,8 @@ examples:
pm8921_gpio: gpio@150 {
compatible = "qcom,pm8921-gpio", "qcom,ssbi-gpio";
reg = <0x150 0x160>;
- interrupts = <192 1>, <193 1>, <194 1>,
- <195 1>, <196 1>, <197 1>,
- <198 1>, <199 1>, <200 1>,
- <201 1>, <202 1>, <203 1>,
- <204 1>, <205 1>, <206 1>,
- <207 1>, <208 1>, <209 1>,
- <210 1>, <211 1>, <212 1>,
- <213 1>, <214 1>, <215 1>,
- <216 1>, <217 1>, <218 1>,
- <219 1>, <220 1>, <221 1>,
- <222 1>, <223 1>, <224 1>,
- <225 1>, <226 1>, <227 1>,
- <228 1>, <229 1>, <230 1>,
- <231 1>, <232 1>, <233 1>,
- <234 1>, <235 1>;
-
+ interrupt-controller;
+ #interrupt-cells = <2>;
gpio-controller;
gpio-ranges = <&pm8921_gpio 0 0 44>;
#gpio-cells = <2>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Add gpio-ranges and "qcom,spmi-gpio" compatible to match with the
parent qcom,pmic-gpio.yaml binding.
Signed-off-by: satya priya <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
Reviewed-by: Guru Das Srinagesh <[email protected]>
---
Changes in V7:
- This is newly added in V7 to resolve below error.
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/qcom,pm8008.example.dt.yaml: gpio@c000: compatible: ['qcom,pm8008-gpio'] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/qcom,pm8008.example.dt.yaml: gpio@c000: 'gpio-ranges' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
Changes in RESEND V7:
- Rebased on linux-next.
Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
index 7799368..ec3138c 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
@@ -53,7 +53,9 @@ patternProperties:
properties:
compatible:
- const: qcom,pm8008-gpio
+ items:
+ - const: qcom,pm8008-gpio
+ - const: qcom,spmi-gpio
reg:
description: Peripheral address of one of the two GPIO peripherals.
@@ -61,6 +63,9 @@ patternProperties:
gpio-controller: true
+ gpio-ranges:
+ maxItems: 1
+
interrupt-controller: true
"#interrupt-cells":
@@ -75,6 +80,7 @@ patternProperties:
- gpio-controller
- interrupt-controller
- "#gpio-cells"
+ - gpio-ranges
- "#interrupt-cells"
additionalProperties: false
@@ -107,10 +113,11 @@ examples:
interrupt-parent = <&tlmm>;
interrupts = <32 IRQ_TYPE_EDGE_RISING>;
- gpio@c000 {
- compatible = "qcom,pm8008-gpio";
+ pm8008_gpios: gpio@c000 {
+ compatible = "qcom,pm8008-gpio", "qcom,spmi-gpio";
reg = <0xc000>;
gpio-controller;
+ gpio-ranges = <&pm8008_gpios 0 0 2>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
On Mon, 02 Aug 2021, satya priya wrote:
> Add gpio-ranges and "qcom,spmi-gpio" compatible to match with the
> parent qcom,pmic-gpio.yaml binding.
>
> Signed-off-by: satya priya <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> Reviewed-by: Bjorn Andersson <[email protected]>
> Reviewed-by: Guru Das Srinagesh <[email protected]>
> ---
> Changes in V7:
> - This is newly added in V7 to resolve below error.
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/qcom,pm8008.example.dt.yaml: gpio@c000: compatible: ['qcom,pm8008-gpio'] is too short
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/qcom,pm8008.example.dt.yaml: gpio@c000: 'gpio-ranges' is a required property
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
>
> Changes in RESEND V7:
> - Rebased on linux-next.
>
> Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Hi Linus,
Can you pls merge these patches? I have rebased them on linux-next.
Thanks,
Satya Priya
On 2021-08-02 18:51, satya priya wrote:
> Hi,
>
> I've rebased this series on linux-next. Patch [1/3] of this series is
> already applied but I'm resending it just to avoid Bot errors.
>
> Thanks,
> Satya Priya
>
> satya priya (3):
> dt-bindings: mfd: pm8008: Add gpio-ranges and spmi-gpio compatible
> dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings
> to YAML
> dt-bindings: pinctrl: qcom-pmic-gpio: Remove the interrupts property
>
> .../devicetree/bindings/mfd/qcom,pm8008.yaml | 13 +-
> .../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 290
> ---------------------
> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 239
> +++++++++++++++++
> 3 files changed, 249 insertions(+), 293 deletions(-)
> delete mode 100644
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> create mode 100644
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
On Mon, Aug 2, 2021 at 3:22 PM satya priya <[email protected]> wrote:
> Remove the interrupts property as we no longer specify it.
>
> Signed-off-by: satya priya <[email protected]>
> Acked-by: Rob Herring <[email protected]>
> Reviewed-by: Bjorn Andersson <[email protected]>
Patch applied!
Yours,
Linus Walleij
On Wed, Aug 11, 2021 at 8:17 AM <[email protected]> wrote:
> Can you pls merge these patches? I have rebased them on linux-next.
Yeah I tried, hope it worked. Sorry for the delay.
Yours,
Linus Walleij