2016-03-04 15:27:18

by Andreas Ziegler

Subject: Left-over select to PUBLIC_KEY_ALGO_RSA

Hi David,

your patch "akcipher: Move the RSA DER encoding check to the crypto
layer" showed up in linux-next today as commit d43de6c780a8 (that is,
next-20160304).

It removes the CONFIG_PUBLIC_KEY_ALGO_RSA option, but does leave one
reference to it in place inside security/integrity/Kconfig, in the
definition of CONFIG_INTEGRITY_ASYMMETRIC_KEYS.

As the corresponding option is gone, the select statement can safely be
removed. Should I prepare a simple patch for that?

I detected this by using scripts/checkkconfigsymbols on today's and
yesterday's linux-next trees (i.e., "./scripts/checkkconfigsymbols.py -d
next-20160303..next-20160304").

Best regards,

Andreas

2016-03-04 15:23:54

by David Howells

Subject: Re: Left-over select to PUBLIC_KEY_ALGO_RSA

Andreas Ziegler <[email protected]> wrote:

> As the corresponding option is gone, the select statement can safely be
> removed. Should I prepare a simple patch for that?

Please.

> I detected this by using scripts/checkkconfigsymbols on today's and
> yesterday's linux-next trees (i.e., "./scripts/checkkconfigsymbols.py -d
> next-20160303..next-20160304").

Interesting - I didn't realise that exists. This sort of consistency check
should be run every time the Kconfig files are parsed.

Thanks,
David

2016-03-04 18:00:32

by Andreas Ziegler

Subject: [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA

Commit d43de6c780a8 ("akcipher: Move the RSA DER encoding check to
the crypto layer") removed the Kconfig option PUBLIC_KEY_ALGO_RSA,
but forgot to remove a 'select' to this option in the definition of
INTEGRITY_ASYMMETRIC_KEYS.

Let's remove the select, as it's ineffective now.

Signed-off-by: Andreas Ziegler <[email protected]>
---
security/integrity/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 979be65..da95658 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -35,7 +35,6 @@ config INTEGRITY_ASYMMETRIC_KEYS
default n
select ASYMMETRIC_KEY_TYPE
select ASYMMETRIC_PUBLIC_KEY_SUBTYPE
- select PUBLIC_KEY_ALGO_RSA
select CRYPTO_RSA
select X509_CERTIFICATE_PARSER
help
--
1.9.1

2016-03-07 15:00:07

by David Howells

Subject: Re: [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA

Andreas Ziegler <[email protected]> wrote:

> Commit d43de6c780a8 ("akcipher: Move the RSA DER encoding check to
> the crypto layer") removed the Kconfig option PUBLIC_KEY_ALGO_RSA,
> but forgot to remove a 'select' to this option in the definition of
> INTEGRITY_ASYMMETRIC_KEYS.
>
> Let's remove the select, as it's ineffective now.
>
> Signed-off-by: Andreas Ziegler <[email protected]>

Applied.