2011-05-09 00:33:24

by Samuel Ortiz

Subject: [PATCH 06/19] mfd: Pass htc-pasic3 led platform data through the cell platform_data

Cc: Philipp Zabel <[email protected]>
Signed-off-by: Samuel Ortiz <[email protected]>
---
drivers/mfd/htc-pasic3.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/htc-pasic3.c b/drivers/mfd/htc-pasic3.c
index 95a4ff4..2808bd1 100644
--- a/drivers/mfd/htc-pasic3.c
+++ b/drivers/mfd/htc-pasic3.c
@@ -173,6 +173,8 @@ static int __init pasic3_probe(struct platform_device *pdev)
}

if (pdata && pdata->led_pdata) {
+ led_cell.platform_data = pdata->led_pdata;
+ led_cell.pdata_size = sizeof(struct pasic3_leds_machinfo);
ret = mfd_add_devices(&pdev->dev, pdev->id, &led_cell, 1, r, 0);
if (ret < 0)
dev_warn(dev, "failed to register LED device\n");
--
1.7.2.3

2011-05-09 10:20:19

by Paul Parsons

Subject: Re: [PATCH 06/19] mfd: Pass htc-pasic3 led platform data through the cell platform_data

Hi Samuel,

I presume an earlier post called "mfd: Remove mfd_data" provided the patch for struct mfd_cell. If so would you please forward it to the list since I have no visibility of the change. Perhaps linux-kernel bounced the original post?

Regards,
Paul

--- On Mon, 9/5/11, Samuel Ortiz <[email protected]> wrote:

> diff --git a/drivers/mfd/htc-pasic3.c
> b/drivers/mfd/htc-pasic3.c
> index 95a4ff4..2808bd1 100644
> --- a/drivers/mfd/htc-pasic3.c
> +++ b/drivers/mfd/htc-pasic3.c
> @@ -173,6 +173,8 @@ static int __init pasic3_probe(struct
> platform_device *pdev)
> ??? }
>
> ??? if (pdata &&
> pdata->led_pdata) {
> +??? ???
> led_cell.platform_data = pdata->led_pdata;
> +??? ??? led_cell.pdata_size
> = sizeof(struct pasic3_leds_machinfo);
> ??? ??? ret =
> mfd_add_devices(&pdev->dev, pdev->id,
> &led_cell, 1, r, 0);
> ??? ??? if (ret < 0)
> ??? ??? ???
> dev_warn(dev, "failed to register LED device\n");

2011-05-09 11:25:59

by Samuel Ortiz

Subject: Re: [PATCH 06/19] mfd: Pass htc-pasic3 led platform data through the cell platform_data

Hi Paul,

On Mon, May 09, 2011 at 11:20:16AM +0100, Paul Parsons wrote:
> Hi Samuel,
>
> I presume an earlier post called "mfd: Remove mfd_data" provided the patch for struct mfd_cell. If so would you please forward it to the list since I have no visibility of the change. Perhaps linux-kernel bounced the original post?
>
I just realized that it did, yes. Maybe the Cc list was too long.
Anyway, I reposted it to lkml only:
http://lkml.org/lkml/2011/5/9/132

And http://lkml.org/lkml/2011/5/9/131 for the cover letter.

Cheers,
Samuel.


> Regards,
> Paul
>
> --- On Mon, 9/5/11, Samuel Ortiz <[email protected]> wrote:
>
> > diff --git a/drivers/mfd/htc-pasic3.c
> > b/drivers/mfd/htc-pasic3.c
> > index 95a4ff4..2808bd1 100644
> > --- a/drivers/mfd/htc-pasic3.c
> > +++ b/drivers/mfd/htc-pasic3.c
> > @@ -173,6 +173,8 @@ static int __init pasic3_probe(struct
> > platform_device *pdev)
> > ??? }
> >
> > ??? if (pdata &&
> > pdata->led_pdata) {
> > +??? ???
> > led_cell.platform_data = pdata->led_pdata;
> > +??? ??? led_cell.pdata_size
> > = sizeof(struct pasic3_leds_machinfo);
> > ??? ??? ret =
> > mfd_add_devices(&pdev->dev, pdev->id,
> > &led_cell, 1, r, 0);
> > ??? ??? if (ret < 0)
> > ??? ??? ???
> > dev_warn(dev, "failed to register LED device\n");

--
Intel Open Source Technology Centre
http://oss.intel.com/