On 2020-12-16 21:16, Stanley Chu wrote:
> hba->devfreq is zero-initialized thus it is not required
> to check its existence in ufshcd_add_lus() function which
> is invoked during initialization only.
>
> Signed-off-by: Stanley Chu <[email protected]>
> ---
> drivers/scsi/ufs/ufshcd.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index a91b73a1fc48..9cc16598136d 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -7636,15 +7636,13 @@ static int ufshcd_add_lus(struct ufs_hba *hba)
> &hba->pwr_info,
> sizeof(struct ufs_pa_layer_attr));
> hba->clk_scaling.saved_pwr_info.is_valid = true;
> - if (!hba->devfreq) {
Just FYI, checking this was due to consideration for supporting UFS
cards
which can do hot-plug. But UFS cards seems out of the picture for a long
time.
Anyways, if someday UFS cards come back in future, let's add these
checks back again.
Thanks,
Can Guo.
> - hba->clk_scaling.is_allowed = true;
> - ret = ufshcd_devfreq_init(hba);
> - if (ret)
> - goto out;
> + hba->clk_scaling.is_allowed = true;
> + ret = ufshcd_devfreq_init(hba);
> + if (ret)
> + goto out;
>
> - hba->clk_scaling.is_enabled = true;
> - ufshcd_clkscaling_init_sysfs(hba);
> - }
> + hba->clk_scaling.is_enabled = true;
> + ufshcd_clkscaling_init_sysfs(hba);
> }
>
> ufs_bsg_probe(hba);