2022-02-02 13:54:15

by Rafael J. Wysocki

[permalink] [raw]
Subject: [PATCH] thunderbolt: Replace acpi_bus_get_device()

From: Rafael J. Wysocki <[email protected]>

Replace acpi_bus_get_device() that is going to be dropped with
acpi_fetch_acpi_dev().

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/thunderbolt/acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/thunderbolt/acpi.c
===================================================================
--- linux-pm.orig/drivers/thunderbolt/acpi.c
+++ linux-pm/drivers/thunderbolt/acpi.c
@@ -14,15 +14,15 @@
static acpi_status tb_acpi_add_link(acpi_handle handle, u32 level, void *data,
void **return_value)
{
+ struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
struct fwnode_reference_args args;
struct fwnode_handle *fwnode;
struct tb_nhi *nhi = data;
- struct acpi_device *adev;
struct pci_dev *pdev;
struct device *dev;
int ret;

- if (acpi_bus_get_device(handle, &adev))
+ if (!adev)
return AE_OK;

fwnode = acpi_fwnode_handle(adev);




2022-02-02 16:04:05

by Mika Westerberg

[permalink] [raw]
Subject: Re: [PATCH] thunderbolt: Replace acpi_bus_get_device()

On Wed, Feb 02, 2022 at 02:46:26PM +0100, Rafael J. Wysocki wrote:
> On Wed, Feb 2, 2022 at 10:36 AM Mika Westerberg
> <[email protected]> wrote:
> >
> > On Tue, Feb 01, 2022 at 08:12:30PM +0100, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <[email protected]>
> > >
> > > Replace acpi_bus_get_device() that is going to be dropped with
> > > acpi_fetch_acpi_dev().
> > >
> > > No intentional functional impact.
> > >
> > > Signed-off-by: Rafael J. Wysocki <[email protected]>
> >
> > Acked-by: Mika Westerberg <[email protected]>
> >
> > Let me know if you want me to pick this up.
>
> Yes, please, if you can.

Applied to thunderbolt.git/next, thanks!

2022-02-03 14:06:46

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] thunderbolt: Replace acpi_bus_get_device()

On Wed, Feb 2, 2022 at 10:36 AM Mika Westerberg
<[email protected]> wrote:
>
> On Tue, Feb 01, 2022 at 08:12:30PM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <[email protected]>
> >
> > Replace acpi_bus_get_device() that is going to be dropped with
> > acpi_fetch_acpi_dev().
> >
> > No intentional functional impact.
> >
> > Signed-off-by: Rafael J. Wysocki <[email protected]>
>
> Acked-by: Mika Westerberg <[email protected]>
>
> Let me know if you want me to pick this up.

Yes, please, if you can.

2022-02-03 21:29:20

by Mika Westerberg

[permalink] [raw]
Subject: Re: [PATCH] thunderbolt: Replace acpi_bus_get_device()

On Tue, Feb 01, 2022 at 08:12:30PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> Replace acpi_bus_get_device() that is going to be dropped with
> acpi_fetch_acpi_dev().
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>

Acked-by: Mika Westerberg <[email protected]>

Let me know if you want me to pick this up.