2014-10-07 20:31:49

by Fabian Frédérick

Subject: [PATCH 1/1 net-next] netlabel: kernel-doc warning fix

no secid argument in netlbl_cfg_unlbl_static_del

Signed-off-by: Fabian Frederick <[email protected]>
---
net/netlabel/netlabel_kapi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c
index 0b4692d..a845cd4 100644
--- a/net/netlabel/netlabel_kapi.c
+++ b/net/netlabel/netlabel_kapi.c
@@ -246,7 +246,6 @@ int netlbl_cfg_unlbl_static_add(struct net *net,
* @addr: IP address in network byte order (struct in[6]_addr)
* @mask: address mask in network byte order (struct in[6]_addr)
* @family: address family
- * @secid: LSM secid value for the entry
* @audit_info: NetLabel audit information
*
* Description:
--
1.9.3

2014-10-07 22:13:38

by Paul Moore

Subject: Re: [PATCH 1/1 net-next] netlabel: kernel-doc warning fix

On Tuesday, October 07, 2014 10:31:32 PM Fabian Frederick wrote:
> no secid argument in netlbl_cfg_unlbl_static_del
>
> Signed-off-by: Fabian Frederick <[email protected]>

Thanks. Likely a copy/paste error from netlbl_cfg_unlbl_static_add().

Acked-by: Paul Moore <[email protected]>

> ---
> net/netlabel/netlabel_kapi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c
> index 0b4692d..a845cd4 100644
> --- a/net/netlabel/netlabel_kapi.c
> +++ b/net/netlabel/netlabel_kapi.c
> @@ -246,7 +246,6 @@ int netlbl_cfg_unlbl_static_add(struct net *net,
> * @addr: IP address in network byte order (struct in[6]_addr)
> * @mask: address mask in network byte order (struct in[6]_addr)
> * @family: address family
> - * @secid: LSM secid value for the entry
> * @audit_info: NetLabel audit information
> *
> * Description:

--
paul moore
http://www.paul-moore.com

2014-10-08 00:31:06

by David Miller

Subject: Re: [PATCH 1/1 net-next] netlabel: kernel-doc warning fix

From: Paul Moore <[email protected]>
Date: Tue, 07 Oct 2014 18:13:34 -0400

> On Tuesday, October 07, 2014 10:31:32 PM Fabian Frederick wrote:
>> no secid argument in netlbl_cfg_unlbl_static_del
>>
>> Signed-off-by: Fabian Frederick <[email protected]>
>
> Thanks. Likely a copy/paste error from netlbl_cfg_unlbl_static_add().
>
> Acked-by: Paul Moore <[email protected]>

Applied, thanks everyone.