2021-12-01 17:53:52

by Mathieu Poirier

Subject: [PATCH] MAINTAINERS: Removing Ohad from remoteproc/rpmsg maintenance

Ohad has not reviewed patches in the remoteproc and rpmsg subsystems for
several years now:

$ git log --no-merges --format=email drivers/remoteproc/ drivers/rpmsg/ | \
grep -Pi "^Subject:|^Date:|^\w+-by:.*ohad*" | grep -B2 ohad

Date: Thu, 12 Mar 2015 11:54:41 +1030
Subject: [PATCH] virtio_rpmsg: set DRIVER_OK before using device
Acked-by: Ohad Ben-Cohen <[email protected]>
--
Date: Mon, 15 Jul 2013 11:24:08 +0930
Subject: [PATCH] remoteproc: don't use PTR_RET().
Acked-by: Ohad Ben-Cohen <[email protected]>
--
Date: Thu, 14 Feb 2013 17:53:18 +0100
Subject: [PATCH] remoteproc: omap: depend on OMAP_MBOX_FWK
Acked-by: Ohad Ben-Cohen <[email protected]>

As such move his names to the CREDITS file.

Signed-off-by: Mathieu Poirier <[email protected]>

---
Credits to Joe Perches for the script [1].

[1]. https://www.spinics.net/lists/kernel/msg4163272.html
---

CREDITS | 5 +++++
MAINTAINERS | 2 --
2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/CREDITS b/CREDITS
index d8f63e8329e8..504e026ca132 100644
--- a/CREDITS
+++ b/CREDITS
@@ -315,6 +315,11 @@ S: Via Delle Palme, 9
S: Terni 05100
S: Italy

+N: Ohad Ben-Cohen
+E: [email protected]
+D: Contribution to remoteproc subsystem
+D: contribution to RPMSG subsystem
+
N: Krzysztof Benedyczak
E: [email protected]
W: http://www.mat.uni.torun.pl/~golbi
diff --git a/MAINTAINERS b/MAINTAINERS
index 7a2345ce8521..ee82a598b3ba 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16171,7 +16171,6 @@ S: Supported
F: fs/reiserfs/

REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM
-M: Ohad Ben-Cohen <[email protected]>
M: Bjorn Andersson <[email protected]>
M: Mathieu Poirier <[email protected]>
L: [email protected]
@@ -16185,7 +16184,6 @@ F: include/linux/remoteproc.h
F: include/linux/remoteproc/

REMOTE PROCESSOR MESSAGING (RPMSG) SUBSYSTEM
-M: Ohad Ben-Cohen <[email protected]>
M: Bjorn Andersson <[email protected]>
M: Mathieu Poirier <[email protected]>
L: [email protected]
--
2.25.1

2021-12-01 18:19:23

by Ohad Ben Cohen

Subject: Re: [PATCH] MAINTAINERS: Removing Ohad from remoteproc/rpmsg maintenance

Hi Mathieu,

Thanks for the patch, please use the below

On Wed, Dec 1, 2021 at 7:53 PM Mathieu Poirier
<[email protected]> wrote:
> +N: Ohad Ben-Cohen
> +E: [email protected]
> +D: Contribution to remoteproc subsystem
> +D: contribution to RPMSG subsystem

N: Ohad Ben Cohen
E: [email protected]
D: Remote Processor (remoteproc) subsystem
D: Remote Processor Messaging (rpmsg) subsystem

2021-12-01 21:00:26

by Joe Perches

Subject: Re: [PATCH] MAINTAINERS: Removing Ohad from remoteproc/rpmsg maintenance

On Wed, 2021-12-01 at 10:53 -0700, Mathieu Poirier wrote:
> Ohad has not reviewed patches in the remoteproc and rpmsg subsystems for
> several years now:
>
> $ git log --no-merges --format=email drivers/remoteproc/ drivers/rpmsg/ | \
> grep -Pi "^Subject:|^Date:|^\w+-by:.*ohad*" | grep -B2 ohad
[]
> ---
> Credits to Joe Perches for the script [1].
>
> [1]. https://www.spinics.net/lists/kernel/msg4163272.html

Oops. bad script.

It needs to have a - in the grep to include "Signed-off-by:"

$ git log --no-merges --format=email drivers/remoteproc/ drivers/rpmsg/ | \
grep -Pi "^Subject:|^Date:|^[\w\-]+-by:.*ohad*" | grep -B2 ohad