2014-10-01 14:39:18

by Guan Xuetao

[permalink] [raw]
Subject: 回复: Re: [PATCH] unicore32: Remove u nneeded Kconfig entry NO_IOPORT_MAP


----- Paul Bolle <[email protected]> 写道:
> On Sun, 2014-09-28 at 09:49 +0800, Xuetao Guan wrote:
> > Sorry for late reply.
>
> You replied within four days. That's rather quick, actually.
>
> > I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig
> > Sure, removing it means no different for .config file.
> > I think a better way is reserving it
>
> I'm not sure I get what you're saying here: what do mean with "reserving
> it"?

I mean, it's better to keep the code unchanged.

>
> > or moving it into arch/Kconfig
>
> Without a (treewide) patch I find it hard to say whether that's worth
> the trouble. But even if that move would be done, wouldn't it include
> dropping this entry from arch/unicore32 anyway?

IMHO, this config could be removed from kernel code.

>
>
> Paul Bolle
>