2009-04-07 07:49:54

by Luotao Fu

[permalink] [raw]
Subject: [PATCH] USB: serial: add FTDI FT4232H ID

add the ID of FT4232H Hi-Speed quad channel serial converter.

Signed-off-by: Luotao Fu <[email protected]>
---
drivers/usb/serial/ftdi_sio.c | 1 +
drivers/usb/serial/ftdi_sio.h | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index ae84c32..08f5c8a 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -668,6 +668,7 @@ static struct usb_device_id id_table_combined [] = {
{ USB_DEVICE(DE_VID, WHT_PID) },
{ USB_DEVICE(ADI_VID, ADI_GNICE_PID),
.driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
+ { USB_DEVICE(FTDI_VID, FTDI_4232H_PID) },
{ }, /* Optional parameter entry */
{ } /* Terminating entry */
};
diff --git a/drivers/usb/serial/ftdi_sio.h b/drivers/usb/serial/ftdi_sio.h
index daaf63d..e1072b5 100644
--- a/drivers/usb/serial/ftdi_sio.h
+++ b/drivers/usb/serial/ftdi_sio.h
@@ -28,6 +28,7 @@
#define FTDI_8U232AM_ALT_PID 0x6006 /* FTDI's alternate PID for above */
#define FTDI_8U2232C_PID 0x6010 /* Dual channel device */
#define FTDI_232RL_PID 0xFBFA /* Product ID for FT232RL */
+#define FTDI_4232H_PID 0x6011 /* quad channel hi-speed */
#define FTDI_RELAIS_PID 0xFA10 /* Relais device from Rudolf Gugler */
#define FTDI_NF_RIC_VID 0x0DCD /* Vendor Id */
#define FTDI_NF_RIC_PID 0x0001 /* Product Id */
--
1.6.2.1


2009-04-07 08:39:34

by Uwe Bonnes

[permalink] [raw]
Subject: Re: [PATCH] USB: serial: add FTDI FT4232H ID

>>>>> "Luotao" == Luotao Fu <[email protected]> writes:

Luotao> add the ID of FT4232H Hi-Speed quad channel serial converter.

This probably isn't enough to make the devices work.

The FT2232H and FT4432H are High Speed devices with defaul buffer sizes of
512 bytes. A recieve buffer contains two status bytes and then up to 510
bytes of data against 62 bytes on the old devices.

Bye
--
Uwe Bonnes [email protected]

Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2009-04-07 09:04:30

by Luotao Fu

[permalink] [raw]
Subject: Re: [PATCH] USB: serial: add FTDI FT4232H ID

On Tue, Apr 07, 2009 at 10:30:52AM +0200, Uwe Bonnes wrote:
> >>>>> "Luotao" == Luotao Fu <[email protected]> writes:
>
> Luotao> add the ID of FT4232H Hi-Speed quad channel serial converter.
>
> This probably isn't enough to make the devices work.
>
> The FT2232H and FT4432H are High Speed devices with defaul buffer sizes of
> 512 bytes. A recieve buffer contains two status bytes and then up to 510
> bytes of data against 62 bytes on the old devices.

Shame on me. I did only check whether the device with its four channels are
registered. Since the chip is built-in on our board and I still need some
additional libraries to check the devices connected to it. I haven't done any
function tests still. Will keep an eye on this. Sounds that it could be a little
hairy then. Afais the PID 6001 is e.g. shared by common/high speed devices. I
didn't grab deeper in the ftdi code, probably it'll be some way to work around
this.

cheers
Luotao Fu
--
Pengutronix e.K. | Dipl.-Ing. Luotao Fu |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |


Attachments:
(No filename) (1.23 kB)
signature.asc (197.00 B)
Digital signature
Download all attachments

2009-04-07 09:46:58

by Uwe Bonnes

[permalink] [raw]
Subject: Re: [PATCH] USB: serial: add FTDI FT4232H ID

>>>>> "Luotao" == Luotao Fu <[email protected]> writes:

Luotao> On Tue, Apr 07, 2009 at 10:30:52AM +0200, Uwe Bonnes wrote:
>> >>>>> "Luotao" == Luotao Fu <[email protected]> writes:
>>
Luotao> add the ID of FT4232H Hi-Speed quad channel serial converter.
>> This probably isn't enough to make the devices work.
>>
>> The FT2232H and FT4432H are High Speed devices with defaul buffer
>> sizes of 512 bytes. A recieve buffer contains two status bytes and
>> then up to 510 bytes of data against 62 bytes on the old devices.

Luotao> Shame on me. I did only check whether the device with its four
Luotao> channels are registered. Since the chip is built-in on our board
Luotao> and I still need some additional libraries to check the devices
Luotao> connected to it. I haven't done any function tests still. Will
Luotao> keep an eye on this. Sounds that it could be a little hairy
Luotao> then. Afais the PID 6001 is e.g. shared by common/high speed
Luotao> devices. I didn't grab deeper in the ftdi code, probably it'll
Luotao> be some way to work around this.

For libusb access, some work for the H-Type chips has already been don in
libftdi (http://www.intra2net.com/en/developer/libftdi/)

--
Uwe Bonnes [email protected]

Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------