2023-07-05 10:20:12

by Li Chen

Subject: [PATCH] PCI: cadence: remove unused cdns_plat_pcie->is_rc

We already have cdns_plat_pcie_of_data->is_rc.

Signed-off-by: Li Chen <[email protected]>
---
drivers/pci/controller/cadence/pcie-cadence-plat.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/pci/controller/cadence/pcie-cadence-plat.c b/drivers/pci/controller/cadence/pcie-cadence-plat.c
index bac0541317c1..e091fef9c919 100644
--- a/drivers/pci/controller/cadence/pcie-cadence-plat.c
+++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c
@@ -18,12 +18,9 @@
/**
* struct cdns_plat_pcie - private data for this PCIe platform driver
* @pcie: Cadence PCIe controller
- * @is_rc: Set to 1 indicates the PCIe controller mode is Root Complex,
- * if 0 it is in Endpoint mode.
*/
struct cdns_plat_pcie {
struct cdns_pcie *pcie;
- bool is_rc;
};

struct cdns_plat_pcie_of_data {
@@ -77,7 +74,6 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
rc->pcie.dev = dev;
rc->pcie.ops = &cdns_plat_ops;
cdns_plat_pcie->pcie = &rc->pcie;
- cdns_plat_pcie->is_rc = is_rc;

ret = cdns_pcie_init_phy(dev, cdns_plat_pcie->pcie);
if (ret) {
@@ -105,7 +101,6 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
ep->pcie.dev = dev;
ep->pcie.ops = &cdns_plat_ops;
cdns_plat_pcie->pcie = &ep->pcie;
- cdns_plat_pcie->is_rc = is_rc;

ret = cdns_pcie_init_phy(dev, cdns_plat_pcie->pcie);
if (ret) {
--
2.25.1

2023-08-30 20:16:09

by Krzysztof Wilczyński

Subject: Re: [PATCH] PCI: cadence: remove unused cdns_plat_pcie->is_rc

Hello,

> We already have cdns_plat_pcie_of_data->is_rc.

Applied to controller/cadence, thank you!

[1/1] PCI: cadence: Drop unused member from struct cdns_plat_pcie
https://git.kernel.org/pci/pci/c/abc6119edfe8

Krzysztof