2024-05-28 15:02:40

by Rafael J. Wysocki

Subject: [PATCH v2 3/8] thermal/debugfs: Print mitigation timestamp value in milliseconds

From: Rafael J. Wysocki <[email protected]>

Because mitigation episode duration is printed in milliseconds, there
is no reason to print timestamp information for mitigation episodes in
smaller units which also makes it somewhat harder to interpret the
numbers.

Print it in milliseconds for consistency.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---

v1 -> v2: Rebase.

---
drivers/thermal/thermal_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/thermal/thermal_debugfs.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_debugfs.c
+++ linux-pm/drivers/thermal/thermal_debugfs.c
@@ -797,8 +797,8 @@ static int tze_seq_show(struct seq_file
c = '=';
}

- seq_printf(s, ",-Mitigation at %lluus, duration%c%llums\n",
- ktime_to_us(tze->timestamp), c, duration_ms);
+ seq_printf(s, ",-Mitigation at %llums, duration%c%llums\n",
+ ktime_to_ms(tze->timestamp), c, duration_ms);

seq_printf(s, "| trip | type | temp(°mC) | hyst(°mC) | duration | avg(°mC) | min(°mC) | max(°mC) |\n");

2024-06-10 08:29:51

by Daniel Lezcano

Subject: Re: [PATCH v2 3/8] thermal/debugfs: Print mitigation timestamp value in milliseconds

On 28/05/2024 16:55, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> Because mitigation episode duration is printed in milliseconds, there
> is no reason to print timestamp information for mitigation episodes in
> smaller units which also makes it somewhat harder to interpret the
> numbers.
>
> Print it in milliseconds for consistency.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---

Acked-by: Daniel Lezcano <[email protected]>



--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog