2020-08-11 07:04:50

by Gao Xiang

Subject: [PATCH] erofs: avoid duplicated permission check for "trusted." xattrs

Don't recheck it since xattr_permission() already
checks CAP_SYS_ADMIN capability.

Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs")

Reported-by: Hongyu Jin <[email protected]>
[ Gao Xiang: since it could cause some complex Android overlay
permission issue as well on android-5.4+, so it'd be better to
backport to 5.4+ rather than pure cleanup on mainline. ]
Cc: <[email protected]> # 5.4+
Signed-off-by: Gao Xiang <[email protected]>
---
related commit:
https://android-review.googlesource.com/c/kernel/common/+/1121623/6/fs/xattr.c#b284

fs/erofs/xattr.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/erofs/xattr.c b/fs/erofs/xattr.c
index 87e437e7b34f..f86e3247febc 100644
--- a/fs/erofs/xattr.c
+++ b/fs/erofs/xattr.c
@@ -473,8 +473,6 @@ static int erofs_xattr_generic_get(const struct xattr_handler *handler,
return -EOPNOTSUPP;
break;
case EROFS_XATTR_INDEX_TRUSTED:
- if (!capable(CAP_SYS_ADMIN))
- return -EPERM;
break;
case EROFS_XATTR_INDEX_SECURITY:
break;
--
2.18.1

2020-08-12 02:02:29

by Chao Yu

Subject: Re: [PATCH] erofs: avoid duplicated permission check for "trusted." xattrs

On 2020/8/11 15:00, Gao Xiang wrote:
> Don't recheck it since xattr_permission() already
> checks CAP_SYS_ADMIN capability.
>
> Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs")
>
> Reported-by: Hongyu Jin <[email protected]>
> [ Gao Xiang: since it could cause some complex Android overlay
> permission issue as well on android-5.4+, so it'd be better to
> backport to 5.4+ rather than pure cleanup on mainline. ]
> Cc: <[email protected]> # 5.4+
> Signed-off-by: Gao Xiang <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,