2022-05-03 00:20:01

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [PATCH -lkmm] tools/memory-model/README: Update klitmus7 compat table

On Mon, May 02, 2022 at 09:05:09PM +0900, Akira Yokosawa wrote:
> EXPORT_SYMBOL of do_exec() was removed in v5.17. Unfortunately,
> kernel modules from klitmus7 7.56 have do_exec() at the end of
> each kthread.
>
> herdtools7 7.56.1 has addressed the issue.
>
> Update the compatibility table accordingly.
>
> Signed-off-by: Akira Yokosawa <[email protected]>
> Cc: Luc Maranget <[email protected]>
> Cc: Jade Alglave <[email protected]>
> Cc: [email protected] # v5.17+
> ---
> Hi Paul,
>
> herdtools7 release 7.56.1 is available at
> https://github.com/herd/herdtools7/releases/tag/7.56.1,
> and "opam update/upgrade" should catch it soon.

Good catch, thank you!

> I think this is worth for v5.18, albeit it is a minor update
> in documentation.

Good point, but let me give it some thought.

Thanx, Paul

> Thoughts?
>
> Thanks, Akira
> --
> tools/memory-model/README | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/memory-model/README b/tools/memory-model/README
> index 9edd402704c4..dab38904206a 100644
> --- a/tools/memory-model/README
> +++ b/tools/memory-model/README
> @@ -54,7 +54,8 @@ klitmus7 Compatibility Table
> -- 4.14 7.48 --
> 4.15 -- 4.19 7.49 --
> 4.20 -- 5.5 7.54 --
> - 5.6 -- 7.56 --
> + 5.6 -- 5.16 7.56 --
> + 5.17 -- 7.56.1 --
> ============ ==========
>
>
> --
> 2.25.1
>


2022-05-08 19:06:39

by Akira Yokosawa

[permalink] [raw]
Subject: Re: [PATCH -lkmm] tools/memory-model/README: Update klitmus7 compat table

On Mon, 2 May 2022 09:50:58 -0700,
Paul E. McKenney wrote:
> On Mon, May 02, 2022 at 09:05:09PM +0900, Akira Yokosawa wrote:
>> EXPORT_SYMBOL of do_exec() was removed in v5.17. Unfortunately,
>> kernel modules from klitmus7 7.56 have do_exec() at the end of
>> each kthread.
>>
>> herdtools7 7.56.1 has addressed the issue.
>>
>> Update the compatibility table accordingly.
>>
>> Signed-off-by: Akira Yokosawa <[email protected]>
>> Cc: Luc Maranget <[email protected]>
>> Cc: Jade Alglave <[email protected]>
>> Cc: [email protected] # v5.17+
>> ---
>> Hi Paul,
>>
>> herdtools7 release 7.56.1 is available at
>> https://github.com/herd/herdtools7/releases/tag/7.56.1,
>> and "opam update/upgrade" should catch it soon.

With the help of Luc, opam repository has accepted 7.56.1.

>
> Good catch, thank you!
>
>> I think this is worth for v5.18, albeit it is a minor update
>> in documentation.
>
> Good point, but let me give it some thought.

On the second thought, as v5.18-rc6 is expected this weekend,
I'm OK if this update makes the next (v5.19) merge window.

This is more of a "news" type update and the "Cc: stable" tag
should work either way.

Thanks, Akira

>
> Thanx, Paul
>
>> Thoughts?
>>
>> Thanks, Akira
[...]

2022-05-09 07:24:10

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [PATCH -lkmm] tools/memory-model/README: Update klitmus7 compat table

On Fri, May 06, 2022 at 11:55:02AM +0900, Akira Yokosawa wrote:
> On Mon, 2 May 2022 09:50:58 -0700,
> Paul E. McKenney wrote:
> > On Mon, May 02, 2022 at 09:05:09PM +0900, Akira Yokosawa wrote:
> >> EXPORT_SYMBOL of do_exec() was removed in v5.17. Unfortunately,
> >> kernel modules from klitmus7 7.56 have do_exec() at the end of
> >> each kthread.
> >>
> >> herdtools7 7.56.1 has addressed the issue.
> >>
> >> Update the compatibility table accordingly.
> >>
> >> Signed-off-by: Akira Yokosawa <[email protected]>
> >> Cc: Luc Maranget <[email protected]>
> >> Cc: Jade Alglave <[email protected]>
> >> Cc: [email protected] # v5.17+
> >> ---
> >> Hi Paul,
> >>
> >> herdtools7 release 7.56.1 is available at
> >> https://github.com/herd/herdtools7/releases/tag/7.56.1,
> >> and "opam update/upgrade" should catch it soon.
>
> With the help of Luc, opam repository has accepted 7.56.1.
>
> >
> > Good catch, thank you!
> >
> >> I think this is worth for v5.18, albeit it is a minor update
> >> in documentation.
> >
> > Good point, but let me give it some thought.
>
> On the second thought, as v5.18-rc6 is expected this weekend,
> I'm OK if this update makes the next (v5.19) merge window.
>
> This is more of a "news" type update and the "Cc: stable" tag
> should work either way.

Sounds like a plan! I have this commit positioned to be the LKMM
pull request for the upcoming merge window.

Thanx, Paul