2023-09-15 20:35:08

by Rob Herring (Arm)

[permalink] [raw]

Subject: [PATCH] dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes

---

The PATA child node schema is missing constraints to prevent unknown
properties. As none of the users of this common binding extend the child
nodes with additional properties, adding "additionalProperties: false"
here is sufficient.

Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/ata/pata-common.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/ata/pata-common.yaml b/Documentation/devicetree/bindings/ata/pata-common.yaml
index 337ddf1113c4..4e867dd4d402 100644
--- a/Documentation/devicetree/bindings/ata/pata-common.yaml
+++ b/Documentation/devicetree/bindings/ata/pata-common.yaml
@@ -38,6 +38,7 @@ patternProperties:
ID number 0 and the slave drive will have ID number 1. The PATA port
nodes will be named "ide-port".
type: object
+ additionalProperties: false

properties:
reg:
--
2.40.1

2023-09-15 21:21:37

by Conor Dooley

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes

---

On Fri, Sep 15, 2023 at 03:16:20PM -0500, Rob Herring wrote:
> The PATA child node schema is missing constraints to prevent unknown
> properties. As none of the users of this common binding extend the child
> nodes with additional properties, adding "additionalProperties: false"
> here is sufficient.
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

> ---
> Documentation/devicetree/bindings/ata/pata-common.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/pata-common.yaml b/Documentation/devicetree/bindings/ata/pata-common.yaml
> index 337ddf1113c4..4e867dd4d402 100644
> --- a/Documentation/devicetree/bindings/ata/pata-common.yaml
> +++ b/Documentation/devicetree/bindings/ata/pata-common.yaml
> @@ -38,6 +38,7 @@ patternProperties:
> ID number 0 and the slave drive will have ID number 1. The PATA port
> nodes will be named "ide-port".
> type: object
> + additionalProperties: false
>
> properties:
> reg:
> --
> 2.40.1
>

---

Attachments:

(No filename) (1.10 kB)
signature.asc (235.00 B)
Download all attachments

2023-09-19 17:19:57

by Damien Le Moal

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes

---

On 2023/09/15 13:16, Rob Herring wrote:
> The PATA child node schema is missing constraints to prevent unknown
> properties. As none of the users of this common binding extend the child
> nodes with additional properties, adding "additionalProperties: false"
> here is sufficient.
>
> Signed-off-by: Rob Herring <[email protected]>

Applied to for-6.6-fixes. Thanks !

> ---
> Documentation/devicetree/bindings/ata/pata-common.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/pata-common.yaml b/Documentation/devicetree/bindings/ata/pata-common.yaml
> index 337ddf1113c4..4e867dd4d402 100644
> --- a/Documentation/devicetree/bindings/ata/pata-common.yaml
> +++ b/Documentation/devicetree/bindings/ata/pata-common.yaml
> @@ -38,6 +38,7 @@ patternProperties:
> ID number 0 and the slave drive will have ID number 1. The PATA port
> nodes will be named "ide-port".
> type: object
> + additionalProperties: false
>
> properties:
> reg:

--
Damien Le Moal
Western Digital Research