2020-04-28 16:17:41

by Markus Elfring

[permalink] [raw]
Subject: Re: [PATCH] drm/mcde: dsi: Fix a return value check in mcde_dsi_bind()

> In case of error, the function of_drm_find_bridge() returns NULL pointer
> not ERR_PTR().

Such information is helpful.


> The IS_ERR() test in the return value check should be
> replaced with NULL test.

* Would you like to convert this description into an imperative wording?

* Please fix the patch subject according to a function name.

* How do you think about to add the tag “Fixes” to the commit message
because of an adjustment for the error detection?

Regards,
Markus