2003-06-05 20:55:20

by Daniele Pala

[permalink] [raw]
Subject: [2.5.70][PPC] Small change to config

Since "control" and "platinum" display support doesn't compile if /dev/nvram suppor is selected as a module, here's this
small patch. The problem is that the suppor for /dev/nvram is asked after the "control" and "platinum" support...
Cheers,
Daniele


--- a/drivers/video/Kconfig Fri Jan 1 02:39:17 1904
+++ b/drivers/video/Kconfig Fri Jan 1 02:42:54 1904
@@ -242,14 +242,14 @@

config FB_CONTROL
bool "Apple \"control\" display support"
- depends on FB && PPC && ALL_PPC
+ depends on FB && PPC && ALL_PPC && NVRAM=y
help
This driver supports a frame buffer for the graphics adapter in the
Power Macintosh 7300 and others.

config FB_PLATINUM
bool "Apple \"platinum\" display support"
- depends on FB && PPC && ALL_PPC
+ depends on FB && PPC && ALL_PPC && NVRAM=y
help
This driver supports a frame buffer for the "platinum" graphics
adapter in some Power Macintoshes.


2003-06-06 07:19:39

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: [2.5.70][PPC] Small change to config

On Wed, 1969-12-31 at 23:59, Daniele Pala wrote:
> Since "control" and "platinum" display support doesn't compile if /dev/nvram suppor is selected as a module, here's this
> small patch. The problem is that the suppor for /dev/nvram is asked after the "control" and "platinum" support...
> Cheers,

The proper fix is for those drivers to use the low level nvram access
functions and have those always built in on pmac, the config option
beeing only useful for the char device wrapper...

Anyway, pmac stuff in 2.5 is about to be significantly changed once
I'm done with the move to the new driver model, hopefully, I'll fix
those things along.

Ben.

2003-06-06 20:59:38

by Daniele Pala

[permalink] [raw]
Subject: Re: [2.5.70][PPC] Small change to config

On Fri, Jun 06, 2003 at 09:45:26AM +0200, Martin Zwickel wrote:
> On Fri, 1 Jan 1904 02:51:54 +0100
> Daniele Pala <[email protected]> bubbled:
>
> > Date: Fri, 1 Jan 1904 02:51:54 +0100
>
> just a hint:
> would be nice if you set your date and time correctly ... ;)
>
> Regards,
> Martin
>

mmmm...yeah, of course my clock is 1 minute late. sorry :)
Cheers,
Daniele