2018-09-27 01:40:49

by Leonardo Brás

[permalink] [raw]

Subject: [PATCH v2 1/7] drivers: dio: Avoids building driver if CONFIG_DIO is disabled

---

Avoids building driver if 'make drivers/dio/' is called and
CONFIG_DIO is disabled.

Signed-off-by: Leonardo Brás <[email protected]>
---
drivers/dio/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dio/Makefile b/drivers/dio/Makefile
index ae92d17083f2..f5cffe232448 100644
--- a/drivers/dio/Makefile
+++ b/drivers/dio/Makefile
@@ -2,4 +2,4 @@
# Makefile for the linux kernel.
#

-obj-y := dio.o dio-driver.o dio-sysfs.o
+obj-$(CONFIG_DIO) := dio.o dio-driver.o dio-sysfs.o
\ No newline at end of file
--
2.19.0

2018-09-27 06:37:53

by Rolf Eike Beer

[permalink] [raw]

Subject: Re: [PATCH v2 1/7] drivers: dio: Avoids building driver if CONFIG_DIO is disabled

---

Am Donnerstag, 27. September 2018, 03:39:56 CEST schrieb Leonardo Br?s:
> Avoids building driver if 'make drivers/dio/' is called and
> CONFIG_DIO is disabled.
>
> Signed-off-by: Leonardo Br?s <[email protected]>
> ---
> drivers/dio/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dio/Makefile b/drivers/dio/Makefile
> index ae92d17083f2..f5cffe232448 100644
> --- a/drivers/dio/Makefile
> +++ b/drivers/dio/Makefile
> @@ -2,4 +2,4 @@
> # Makefile for the linux kernel.
> #
>
> -obj-y := dio.o dio-driver.o dio-sysfs.o
> +obj-$(CONFIG_DIO) := dio.o dio-driver.o dio-sysfs.o
> \ No newline at end of file
^^^^^^^^^^^^^^^^^^

One more.

---

Attachments:

signature.asc (201.00 B)
This is a digitally signed message part.

2018-09-27 11:20:24

by Leonardo Brás

[permalink] [raw]

Subject: Re: [PATCH v2 1/7] drivers: dio: Avoids building driver if CONFIG_DIO is disabled

---

Dear Rolf,

On Thu, Sep 27, 2018 at 3:35 AM, Rolf Eike Beer <[email protected]> wrote:
> Am Donnerstag, 27. September 2018, 03:39:56 CEST schrieb Leonardo Brás:
>> Avoids building driver if 'make drivers/dio/' is called and
>> CONFIG_DIO is disabled.
>>
>> Signed-off-by: Leonardo Brás <[email protected]>
>> ---
>> drivers/dio/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dio/Makefile b/drivers/dio/Makefile
>> index ae92d17083f2..f5cffe232448 100644
>> --- a/drivers/dio/Makefile
>> +++ b/drivers/dio/Makefile
>> @@ -2,4 +2,4 @@
>> # Makefile for the linux kernel.
>> #
>>
>> -obj-y := dio.o dio-driver.o dio-sysfs.o
>> +obj-$(CONFIG_DIO) := dio.o dio-driver.o dio-sysfs.o
>> \ No newline at end of file
> ^^^^^^^^^^^^^^^^^^
>
> One more.

Thanks, I will fix this for v3.