2021-10-20 16:39:15

by Caleb Connolly

Subject: [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel

Like the c630, the OnePlus 6 is also capable of using both antenna
channels for 2.4 and 5ghz wifi, however unlike the c630 only the first
channel is used for bluetooth.

Signed-off-by: Caleb Connolly <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index d4355522374a..8bf2430a3af7 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};

+ vreg_l23a_3p3: ldo23 {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3312000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
vdda_qusb_hs0_3p1:
vreg_l24a_3p075: ldo24 {
regulator-min-microvolt = <3088000>;
@@ -647,6 +653,7 @@ &wifi {
vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+ vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;

qcom,snoc-host-cap-8bit-quirk;
};
--
2.33.1

2021-10-20 17:16:21

by Steev Klimaszewski

Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel

Hi Caleb,

On 10/20/21 11:36 AM, Caleb Connolly wrote:
> Like the c630, the OnePlus 6 is also capable of using both antenna
> channels for 2.4 and 5ghz wifi, however unlike the c630 only the first
> channel is used for bluetooth.
>
> Signed-off-by: Caleb Connolly <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> index d4355522374a..8bf2430a3af7 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> + vreg_l23a_3p3: ldo23 {
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3312000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> +
> vdda_qusb_hs0_3p1:
> vreg_l24a_3p075: ldo24 {
> regulator-min-microvolt = <3088000>;
> @@ -647,6 +653,7 @@ &wifi {
> vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
> vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
> + vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>
> qcom,snoc-host-cap-8bit-quirk;
> };
> --
> 2.33.1
>
>
Just for the record, I added it for completeness, as far as I can tell,
the bluetooth driver itself won't use the second channel.


-- steev

2021-10-20 17:27:04

by Caleb Connolly

Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel

Hi Steev,

On 20/10/2021 18:13, Steev Klimaszewski wrote:
> Hi Caleb,
>
> On 10/20/21 11:36 AM, Caleb Connolly wrote:
>> Like the c630, the OnePlus 6 is also capable of using both antenna
>> channels for 2.4 and 5ghz wifi, however unlike the c630 only the first
>> channel is used for bluetooth.
>>
>> Signed-off-by: Caleb Connolly <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> index d4355522374a..8bf2430a3af7 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
>> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> };
>>
>> + vreg_l23a_3p3: ldo23 {
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3312000>;
>> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> + };
>> +
>> vdda_qusb_hs0_3p1:
>> vreg_l24a_3p075: ldo24 {
>> regulator-min-microvolt = <3088000>;
>> @@ -647,6 +653,7 @@ &wifi {
>> vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
>> vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
>> vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>> + vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>>
>> qcom,snoc-host-cap-8bit-quirk;
>> };
>> --
>> 2.33.1
>>
>>
> Just for the record, I added it for completeness, as far as I can tell,
> the bluetooth driver itself won't use the second channel.
Ah I see, I can confirm that the bluetooth hardware is only connected to the first channel on the op6, so with wifi off
the second antenna can also be turned off to save power without affecting bluetooth signal strength.
>
>
> -- steev
>

--
Kind Regards,
Caleb