2015-11-09 14:34:12

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH] [media] mt9t001: constify v4l2_subdev_internal_ops structure

Hi Julia,

Thank you for the patch.

On Sunday 11 October 2015 13:57:13 Julia Lawall wrote:
> This v4l2_subdev_internal_ops structure is never modified. All other
> v4l2_subdev_internal_ops structures are declared as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <[email protected]>

Acked-by: Laurent Pinchart <[email protected]>

and applied to my tree.

> ---
> drivers/media/i2c/mt9t001.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/mt9t001.c b/drivers/media/i2c/mt9t001.c
> index 8ae99f7..4383a5d 100644
> --- a/drivers/media/i2c/mt9t001.c
> +++ b/drivers/media/i2c/mt9t001.c
> @@ -834,7 +834,7 @@ static struct v4l2_subdev_ops mt9t001_subdev_ops = {
> .pad = &mt9t001_subdev_pad_ops,
> };
>
> -static struct v4l2_subdev_internal_ops mt9t001_subdev_internal_ops = {
> +static const struct v4l2_subdev_internal_ops mt9t001_subdev_internal_ops =
> { .registered = mt9t001_registered,
> .open = mt9t001_open,
> .close = mt9t001_close,

--
Regards,

Laurent Pinchart