2019-07-26 06:53:18

by Govind Singh

[permalink] [raw]
Subject: Re: [PATCH 0/3] ath10k: Clean up regulator and clock handling

On 2019-07-25 23:17, Bjorn Andersson wrote:
> The first patch in this series removes the regulator_set_voltage() of a
> fixed
> voltate, as fixed regulator constraints should be specified on a board
> level
> and on certain boards - such as the Lenovo Yoga C630 - the voltage
> specified
> for the 3.3V regulator is outside the given range.
>
> The following two patches cleans up regulator and clock usage by using
> the bulk
> API provided by the two frameworks.
>
> Bjorn Andersson (3):
> ath10k: snoc: skip regulator operations
> ath10k: Use standard regulator bulk API in snoc
> ath10k: Use standard bulk clock API in snoc
>
> drivers/net/wireless/ath/ath10k/snoc.c | 324 ++++---------------------
> drivers/net/wireless/ath/ath10k/snoc.h | 26 +-
> 2 files changed, 48 insertions(+), 302 deletions(-)

Tested on 845 MTP and QCS404 platform with normal sanity and driver
recover cases for proxy votes.

Tested-by: Govind Singh <[email protected]>
Reviewed-by: Govind Singh <[email protected]>

BR,
Govind


2019-08-05 18:06:52

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 0/3] ath10k: Clean up regulator and clock handling

On Thu 25 Jul 23:52 PDT 2019, Govind Singh wrote:

> On 2019-07-25 23:17, Bjorn Andersson wrote:
> > The first patch in this series removes the regulator_set_voltage() of a
> > fixed
> > voltate, as fixed regulator constraints should be specified on a board
> > level
> > and on certain boards - such as the Lenovo Yoga C630 - the voltage
> > specified
> > for the 3.3V regulator is outside the given range.
> >
> > The following two patches cleans up regulator and clock usage by using
> > the bulk
> > API provided by the two frameworks.
> >
> > Bjorn Andersson (3):
> > ath10k: snoc: skip regulator operations
> > ath10k: Use standard regulator bulk API in snoc
> > ath10k: Use standard bulk clock API in snoc
> >
> > drivers/net/wireless/ath/ath10k/snoc.c | 324 ++++---------------------
> > drivers/net/wireless/ath/ath10k/snoc.h | 26 +-
> > 2 files changed, 48 insertions(+), 302 deletions(-)
>
> Tested on 845 MTP and QCS404 platform with normal sanity and driver recover
> cases for proxy votes.
>
> Tested-by: Govind Singh <[email protected]>
> Reviewed-by: Govind Singh <[email protected]>
>

Thanks Govind!

Regards,
Bjorn