2016-10-17 09:10:07

by Matt Redfearn

[permalink] [raw]

Subject: [PATCH] MIPS: Fix build of compressed image

---

Changes introduced to arch/mips/Makefile for the generic kernel resulted
in build errors when making a compressed image if platform-y has multiple
values, like this:

make[2]: *** No rule to make target `alchemy/'.
make[1]: *** [vmlinuz] Error 2
make[1]: Target `_all' not remade because of errors.
make: *** [sub-make] Error 2
make: Target `_all' not remade because of errors.

Fix this by quoting $(platform-y) as it is passed to the Makefile in
arch/mips/boot/compressed/Makefile

Reported-by: kernelci.org bot <[email protected]>
Link: https://storage.kernelci.org/next/next-20161017/mips-gpr_defconfig/build.log
Signed-off-by: Matt Redfearn <[email protected]>

---

arch/mips/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index fbf40d3c8123..1a6bac7b076f 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -263,7 +263,7 @@ KBUILD_CPPFLAGS += -DDATAOFFSET=$(if $(dataoffset-y),$(dataoffset-y),0)

bootvars-y = VMLINUX_LOAD_ADDRESS=$(load-y) \
VMLINUX_ENTRY_ADDRESS=$(entry-y) \
- PLATFORM=$(platform-y)
+ PLATFORM="$(platform-y)"
ifdef CONFIG_32BIT
bootvars-y += ADDR_BITS=32
endif
--
2.7.4

2016-10-17 15:22:33

by Paul Burton

[permalink] [raw]

Subject: Re: [PATCH] MIPS: Fix build of compressed image

---

On Monday, 17 October 2016 10:09:39 BST Matt Redfearn wrote:
> Changes introduced to arch/mips/Makefile for the generic kernel resulted
> in build errors when making a compressed image if platform-y has multiple
> values, like this:
>
> make[2]: *** No rule to make target `alchemy/'.
> make[1]: *** [vmlinuz] Error 2
> make[1]: Target `_all' not remade because of errors.
> make: *** [sub-make] Error 2
> make: Target `_all' not remade because of errors.
>
> Fix this by quoting $(platform-y) as it is passed to the Makefile in
> arch/mips/boot/compressed/Makefile
>
> Reported-by: kernelci.org bot <[email protected]>
> Link:
> https://storage.kernelci.org/next/next-20161017/mips-gpr_defconfig/build.lo
> g Signed-off-by: Matt Redfearn <[email protected]>
>
> ---
>
> arch/mips/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index fbf40d3c8123..1a6bac7b076f 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -263,7 +263,7 @@ KBUILD_CPPFLAGS += -DDATAOFFSET=$(if
> $(dataoffset-y),$(dataoffset-y),0)
>
> bootvars-y = VMLINUX_LOAD_ADDRESS=$(load-y) \
> VMLINUX_ENTRY_ADDRESS=$(entry-y) \
> - PLATFORM=$(platform-y)
> + PLATFORM="$(platform-y)"
> ifdef CONFIG_32BIT
> bootvars-y += ADDR_BITS=32
> endif

Hi Matt,

Reviewed-by: Paul Burton <[email protected]>

Thanks,
Paul

---

Attachments:

signature.asc (801.00 B)
This is a digitally signed message part.