2024-03-26 17:51:12

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: display: rockchip: add missing #sound-dai-cells to dw-hdmi

On 26/03/2024 18:50, Krzysztof Kozlowski wrote:
> On 26/03/2024 18:28, Heiko Stuebner wrote:
>> The #sound-dai-cells DT property is required to describe link between
>> the HDMI IP block and the SoC's audio subsystem.
>>
>> Signed-off-by: Heiko Stuebner <[email protected]>
>> ---
>> .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
>> index af638b6c0d21..3768df80ca7a 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
>> @@ -124,6 +124,9 @@ properties:
>> description:
>> phandle to the GRF to mux vopl/vopb.
>>
>> + "#sound-dai-cells":
>> + const: 0
>> +
>
> Then you miss $ref in allOf to /schemas/sound/dai-common.yaml

I meant, except your change you should add also above $ref.

Best regards,
Krzysztof

2024-03-26 20:01:27

by Heiko Stuebner

Subject: Re: [PATCH] dt-bindings: display: rockchip: add missing #sound-dai-cells to dw-hdmi

Am Dienstag, 26. M?rz 2024, 18:50:37 CET schrieb Krzysztof Kozlowski:
> On 26/03/2024 18:50, Krzysztof Kozlowski wrote:
> > On 26/03/2024 18:28, Heiko Stuebner wrote:
> >> The #sound-dai-cells DT property is required to describe link between
> >> the HDMI IP block and the SoC's audio subsystem.
> >>
> >> Signed-off-by: Heiko Stuebner <[email protected]>
> >> ---
> >> .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> >> index af638b6c0d21..3768df80ca7a 100644
> >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> >> @@ -124,6 +124,9 @@ properties:
> >> description:
> >> phandle to the GRF to mux vopl/vopb.
> >>
> >> + "#sound-dai-cells":
> >> + const: 0
> >> +
> >
> > Then you miss $ref in allOf to /schemas/sound/dai-common.yaml
>
> I meant, except your change you should add also above $ref.

sorry about that, will fix that.

Thanks for the pointer
Heiko