2005-09-01 16:03:40

by Protasevich, Natalie

[permalink] [raw]
Subject: RE: [Hotplug_sig] [patch 1/1] Hot plug CPU to support physical add of new processors (i386)

> Protasevich, Natalie wrote:
> > > > +#ifdef CONFIG_HOTPLUG_CPU
> > > > + if (cpu_online(cpu)) {
> > > > +#else
> > > > if (cpu_online(cpu) || !cpu_present(cpu)) {
> > > > +#endif
> > > > ret = -EINVAL;
> > > > goto out;
> > > > }
> > >
> > > Why this change? I think the cpu_present check is needed for
> > > ppc64 since it has non-present cpus in sysfs.
> > >
> >
> > The new processor was never brought up, its bit is only set in
> > cpu_possible_map, but not in present map.
>
> If a cpu is physically present and is capable of being
> onlined it should be marked in cpu_present_map, please. This
> change would break ppc64; can you rework it?
>
OK, that has to be reworked then. That's what probably Shaohua meant
when mentioned that cpu_present_map has to be cleaned up...
Thanks,
--Natalie