2009-09-01 07:11:12

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: [PATCH 00/18] OMAP: DSS2: Intro

On 08/31/2009 06:55 PM, Tony Lindgren wrote:
> * Hiremath, Vaibhav<[email protected]> [090831 07:44]:
>>
>>> -----Original Message-----
>>> From: [email protected] [mailto:linux-omap-
>>> [email protected]] On Behalf Of Syed Mohammed, Khasim
>>> Sent: Monday, August 31, 2009 8:11 PM
>>> To: Steve Sakoman; Artem Bityutskiy; [email protected];
>>> [email protected] Mailing List
>>> Cc: Andrew Morton; Tony Lindgren; Tomi Valkeinen
>>> Subject: RE: [PATCH 00/18] OMAP: DSS2: Intro
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: [email protected] [mailto:linux-omap-
>>> [email protected]] On Behalf Of Steve
>>>> Sakoman
>>>> Sent: Monday, August 31, 2009 7:50 PM
>>>> To: Artem Bityutskiy
>>>> Cc: Andrew Morton; Tony Lindgren; Tomi Valkeinen; linux-
>>> [email protected]; linux-
>>>> [email protected] Mailing List
>>>> Subject: Re: [PATCH 00/18] OMAP: DSS2: Intro
>>>>
>>>> On Mon, Aug 31, 2009 at 2:23 AM, Artem
>>> Bityutskiy<[email protected]> wrote:
>>>>
>>>>> We are using DSS2 in Nokia for about a year already. N900 is
>>> using this
>>>>> code, for example. Other (non-Nokia) projects are using DSS2 as
>>> well.
>>>>> The code was public for long time and was sent several times for
>>> review.
>>>>>
>>>>> In any case,
>>>>>
>>>>> Tested-by: Artem Bityutskiy<[email protected]>
>>>>
>>>> Gumstix has also been shipping with DSS2 on their Overo product
>>> for
>>>> many months now.
>>>>
>>>> Tested-by: Steve Sakoman<[email protected]>
>>>
>>> If there is a concern on OMAP2 support, I can confirm that there is
>>> no difference between OMAP2 and OMAP3 Display Subsystem from
>>> Register level. So what ever works on OMAP3 DSS2 should straight
>>> away work for OMAP2 as well.
>>>
>>> I agree with rest of the folks here, we should get DSS2 merged in
>>> mainline. It is being extensively used on all OMAP3 platforms.
>>>
>> [Hiremath, Vaibhav] I am also agreeing with the point that we should merge the DSS2; it's now almost year we have migrated to DSS2. Most of our customers are based out of it.
>
> Yeh I agree this should get merged.
>
> I think it's best to merge this via the fb list and I've acked the
> patches that I'm concerned with already.

This would be a good suggestion if the fb list was alive, but it is not.
Do you have a specific name of a maintainer?

Andrew,

could you please help with merging this piece of (well written) code?
Could you give your blessing to include it into linux-next now, and
merge this during the next merge window?

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


2009-09-01 16:08:14

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH 00/18] OMAP: DSS2: Intro

* Artem Bityutskiy <[email protected]> [090901 00:11]:
> On 08/31/2009 06:55 PM, Tony Lindgren wrote:
>> * Hiremath, Vaibhav<[email protected]> [090831 07:44]:
>>>
>>>> -----Original Message-----
>>>> From: [email protected] [mailto:linux-omap-
>>>> [email protected]] On Behalf Of Syed Mohammed, Khasim
>>>> Sent: Monday, August 31, 2009 8:11 PM
>>>> To: Steve Sakoman; Artem Bityutskiy; [email protected];
>>>> [email protected] Mailing List
>>>> Cc: Andrew Morton; Tony Lindgren; Tomi Valkeinen
>>>> Subject: RE: [PATCH 00/18] OMAP: DSS2: Intro
>>>>
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: [email protected] [mailto:linux-omap-
>>>> [email protected]] On Behalf Of Steve
>>>>> Sakoman
>>>>> Sent: Monday, August 31, 2009 7:50 PM
>>>>> To: Artem Bityutskiy
>>>>> Cc: Andrew Morton; Tony Lindgren; Tomi Valkeinen; linux-
>>>> [email protected]; linux-
>>>>> [email protected] Mailing List
>>>>> Subject: Re: [PATCH 00/18] OMAP: DSS2: Intro
>>>>>
>>>>> On Mon, Aug 31, 2009 at 2:23 AM, Artem
>>>> Bityutskiy<[email protected]> wrote:
>>>>>
>>>>>> We are using DSS2 in Nokia for about a year already. N900 is
>>>> using this
>>>>>> code, for example. Other (non-Nokia) projects are using DSS2 as
>>>> well.
>>>>>> The code was public for long time and was sent several times for
>>>> review.
>>>>>>
>>>>>> In any case,
>>>>>>
>>>>>> Tested-by: Artem Bityutskiy<[email protected]>
>>>>>
>>>>> Gumstix has also been shipping with DSS2 on their Overo product
>>>> for
>>>>> many months now.
>>>>>
>>>>> Tested-by: Steve Sakoman<[email protected]>
>>>>
>>>> If there is a concern on OMAP2 support, I can confirm that there is
>>>> no difference between OMAP2 and OMAP3 Display Subsystem from
>>>> Register level. So what ever works on OMAP3 DSS2 should straight
>>>> away work for OMAP2 as well.
>>>>
>>>> I agree with rest of the folks here, we should get DSS2 merged in
>>>> mainline. It is being extensively used on all OMAP3 platforms.
>>>>
>>> [Hiremath, Vaibhav] I am also agreeing with the point that we should merge the DSS2; it's now almost year we have migrated to DSS2. Most of our customers are based out of it.
>>
>> Yeh I agree this should get merged.
>>
>> I think it's best to merge this via the fb list and I've acked the
>> patches that I'm concerned with already.
>
> This would be a good suggestion if the fb list was alive, but it is not.
> Do you have a specific name of a maintainer?

Bummer, I don't know who should ack this then.

> Andrew,
>
> could you please help with merging this piece of (well written) code?
> Could you give your blessing to include it into linux-next now, and
> merge this during the next merge window?

Alternatively I can also pile it into the omap for-next branch if
Andrew prefers that.

It would be nice to get some fb people to ack the drivers/video/omap/
parts of the patch series though.

Tony

2009-09-02 22:11:37

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 00/18] OMAP: DSS2: Intro

On Tue, 01 Sep 2009 10:10:19 +0300
Artem Bityutskiy <[email protected]> wrote:

> Andrew,
>
> could you please help with merging this piece of (well written) code?
> Could you give your blessing to include it into linux-next now, and
> merge this during the next merge window?

I'll merge them (after I've looked through them, which I'll do now).

But there are more rejects than I'm prepared to cope with. The various
arch/arm files have undergone some changes in linux-next which yield
more breakage than I'm prepared to try to fix. For example,
arch/arm/mach-omap2/board-3430sdp.c:sdp3430_config[] ends up being an
empty array!

Then there's the matter of these patches, already in -mm:

omapfb-add-support-for-the-apollon-lcd.patch
omapfb-add-support-for-mipi-dcs-compatible-lcds.patch
omapfb-add-support-for-the-amstrad-delta-lcd.patch
omapfb-add-support-for-the-2430sdp-lcd.patch
omapfb-add-support-for-the-omap2evm-lcd.patch
omapfb-add-support-for-the-3430sdp-lcd.patch
omapfb-add-support-for-the-omap3-evm-lcd.patch
omapfb-add-support-for-the-omap3-beagle-dvi-output.patch
omapfb-add-support-for-the-gumstix-overo-lcd.patch
omapfb-add-support-for-the-zoom-mdk-lcd.patch
omapfb-add-support-for-rotation-on-the-blizzard-lcd-ctrl.patch
n770-enable-lcd-mipi-dcs-in-kconfig.patch
omapfb-dispc-various-typo-fixes.patch
omapfb-dispc-disable-iface-clocks-along-with-func-clocks.patch
omapfb-dispc-enable-wake-up-capability.patch
omapfb-dispc-allow-multiple-external-irq-handlers.patch
omapfb-suspend-resume-only-if-fb-device-is-already-initialized.patch
omapfb-fix-coding-style-remove-dead-line.patch
omapfb-add-fb-manual-update-option-to-kconfig.patch
omapfb-hwa742-fix-pointer-to-be-const.patch

2009-09-03 11:00:17

by Tomi Valkeinen

[permalink] [raw]
Subject: Re: [PATCH 00/18] OMAP: DSS2: Intro

Hi,

On Thu, 2009-09-03 at 00:11 +0200, ext Andrew Morton wrote:
> On Tue, 01 Sep 2009 10:10:19 +0300
> Artem Bityutskiy <[email protected]> wrote:
>
> > Andrew,
> >
> > could you please help with merging this piece of (well written) code?
> > Could you give your blessing to include it into linux-next now, and
> > merge this during the next merge window?
>
> I'll merge them (after I've looked through them, which I'll do now).
>
> But there are more rejects than I'm prepared to cope with. The various
> arch/arm files have undergone some changes in linux-next which yield
> more breakage than I'm prepared to try to fix. For example,
> arch/arm/mach-omap2/board-3430sdp.c:sdp3430_config[] ends up being an
> empty array!

I rebased the patches on top of linux-next. The tree is at
http://gitorious.org/linux-omap-dss2/linux , in branch linux-next-dss.

The only conflict was in board-3430sdp, and yes, sdp3430_config is
supposed to end up as an empty array.

> Then there's the matter of these patches, already in -mm:
>
> omapfb-add-support-for-the-apollon-lcd.patch
> omapfb-add-support-for-mipi-dcs-compatible-lcds.patch
> omapfb-add-support-for-the-amstrad-delta-lcd.patch
> omapfb-add-support-for-the-2430sdp-lcd.patch
> omapfb-add-support-for-the-omap2evm-lcd.patch
> omapfb-add-support-for-the-3430sdp-lcd.patch
> omapfb-add-support-for-the-omap3-evm-lcd.patch
> omapfb-add-support-for-the-omap3-beagle-dvi-output.patch
> omapfb-add-support-for-the-gumstix-overo-lcd.patch
> omapfb-add-support-for-the-zoom-mdk-lcd.patch
> omapfb-add-support-for-rotation-on-the-blizzard-lcd-ctrl.patch
> n770-enable-lcd-mipi-dcs-in-kconfig.patch
> omapfb-dispc-various-typo-fixes.patch
> omapfb-dispc-disable-iface-clocks-along-with-func-clocks.patch
> omapfb-dispc-enable-wake-up-capability.patch
> omapfb-dispc-allow-multiple-external-irq-handlers.patch
> omapfb-suspend-resume-only-if-fb-device-is-already-initialized.patch
> omapfb-fix-coding-style-remove-dead-line.patch
> omapfb-add-fb-manual-update-option-to-kconfig.patch
> omapfb-hwa742-fix-pointer-to-be-const.patch

These are not in linux-next, I think. They are for the old OMAP display
subsystem, and may cause some conflicts with DSS2. I think those patches
should go in also, as the old driver is used for OMAP1 and fo all the
other boards that have not been ported to use DSS2.

Should I rebase DSS2 on top of -mm and solve the conflicts? If so, where
can I find your tree?

Tomi

2009-09-10 18:45:39

by Hiremath, Vaibhav

[permalink] [raw]
Subject: RE: [PATCH 00/18] OMAP: DSS2: Intro


> -----Original Message-----
> From: Tomi Valkeinen [mailto:[email protected]]
> Sent: Thursday, September 03, 2009 4:30 PM
> To: ext Andrew Morton
> Cc: Artem Bityutskiy; [email protected]; Hiremath, Vaibhav; Syed
> Mohammed, Khasim; [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH 00/18] OMAP: DSS2: Intro
>
> Hi,
>
> On Thu, 2009-09-03 at 00:11 +0200, ext Andrew Morton wrote:
> > On Tue, 01 Sep 2009 10:10:19 +0300
> > Artem Bityutskiy <[email protected]> wrote:
> >
> > > Andrew,
> > >
> > > could you please help with merging this piece of (well written)
> code?
> > > Could you give your blessing to include it into linux-next now,
> and
> > > merge this during the next merge window?
> >
> > I'll merge them (after I've looked through them, which I'll do
> now).
> >
> > But there are more rejects than I'm prepared to cope with. The
> various
> > arch/arm files have undergone some changes in linux-next which
> yield
> > more breakage than I'm prepared to try to fix. For example,
> > arch/arm/mach-omap2/board-3430sdp.c:sdp3430_config[] ends up being
> an
> > empty array!
>
> I rebased the patches on top of linux-next. The tree is at
> http://gitorious.org/linux-omap-dss2/linux , in branch linux-next-
> dss.
>
> The only conflict was in board-3430sdp, and yes, sdp3430_config is
> supposed to end up as an empty array.
>
[Hiremath, Vaibhav] I have refreshed OMAp3EVM patch support on top of l-o master, as of now I have shared it under

http://arago-project.org/git/people/?p=vaibhav/ti-psp-omap-video.git;a=summary

under ti_display branch, and will be posting to L-O once DSS2 gets accepted.

> > Then there's the matter of these patches, already in -mm:
> >
> > omapfb-add-support-for-the-apollon-lcd.patch
> > omapfb-add-support-for-mipi-dcs-compatible-lcds.patch
> > omapfb-add-support-for-the-amstrad-delta-lcd.patch
> > omapfb-add-support-for-the-2430sdp-lcd.patch
> > omapfb-add-support-for-the-omap2evm-lcd.patch
> > omapfb-add-support-for-the-3430sdp-lcd.patch
> > omapfb-add-support-for-the-omap3-evm-lcd.patch
> > omapfb-add-support-for-the-omap3-beagle-dvi-output.patch
> > omapfb-add-support-for-the-gumstix-overo-lcd.patch
> > omapfb-add-support-for-the-zoom-mdk-lcd.patch
> > omapfb-add-support-for-rotation-on-the-blizzard-lcd-ctrl.patch
> > n770-enable-lcd-mipi-dcs-in-kconfig.patch
> > omapfb-dispc-various-typo-fixes.patch
> > omapfb-dispc-disable-iface-clocks-along-with-func-clocks.patch
> > omapfb-dispc-enable-wake-up-capability.patch
> > omapfb-dispc-allow-multiple-external-irq-handlers.patch
> > omapfb-suspend-resume-only-if-fb-device-is-already-
> initialized.patch
> > omapfb-fix-coding-style-remove-dead-line.patch
> > omapfb-add-fb-manual-update-option-to-kconfig.patch
> > omapfb-hwa742-fix-pointer-to-be-const.patch
>
> These are not in linux-next, I think. They are for the old OMAP
> display
> subsystem, and may cause some conflicts with DSS2. I think those
> patches
> should go in also, as the old driver is used for OMAP1 and fo all
> the
> other boards that have not been ported to use DSS2.
>
> Should I rebase DSS2 on top of -mm and solve the conflicts? If so,
> where
> can I find your tree?
>
[Hiremath, Vaibhav] Andrew,
We have not heard anything back on this, when are you planning to merge DSS2?

Actually other development patches are gating because of this, like V4L2 driver on top of DSS2.

Thanks,
Vaibhav

> Tomi
>
>

2009-09-17 07:14:16

by Tomi Valkeinen

[permalink] [raw]
Subject: Re: [PATCH 00/18] OMAP: DSS2: Intro

Hi,

On Thu, 2009-09-03 at 00:11 +0200, ext Andrew Morton wrote:
> On Tue, 01 Sep 2009 10:10:19 +0300
> Artem Bityutskiy <[email protected]> wrote:
>
> > Andrew,
> >
> > could you please help with merging this piece of (well written) code?
> > Could you give your blessing to include it into linux-next now, and
> > merge this during the next merge window?
>
> I'll merge them (after I've looked through them, which I'll do now).

Have you had time to take a look at this?

Tomi

>
> But there are more rejects than I'm prepared to cope with. The various
> arch/arm files have undergone some changes in linux-next which yield
> more breakage than I'm prepared to try to fix. For example,
> arch/arm/mach-omap2/board-3430sdp.c:sdp3430_config[] ends up being an
> empty array!
>
> Then there's the matter of these patches, already in -mm:
>
> omapfb-add-support-for-the-apollon-lcd.patch
> omapfb-add-support-for-mipi-dcs-compatible-lcds.patch
> omapfb-add-support-for-the-amstrad-delta-lcd.patch
> omapfb-add-support-for-the-2430sdp-lcd.patch
> omapfb-add-support-for-the-omap2evm-lcd.patch
> omapfb-add-support-for-the-3430sdp-lcd.patch
> omapfb-add-support-for-the-omap3-evm-lcd.patch
> omapfb-add-support-for-the-omap3-beagle-dvi-output.patch
> omapfb-add-support-for-the-gumstix-overo-lcd.patch
> omapfb-add-support-for-the-zoom-mdk-lcd.patch
> omapfb-add-support-for-rotation-on-the-blizzard-lcd-ctrl.patch
> n770-enable-lcd-mipi-dcs-in-kconfig.patch
> omapfb-dispc-various-typo-fixes.patch
> omapfb-dispc-disable-iface-clocks-along-with-func-clocks.patch
> omapfb-dispc-enable-wake-up-capability.patch
> omapfb-dispc-allow-multiple-external-irq-handlers.patch
> omapfb-suspend-resume-only-if-fb-device-is-already-initialized.patch
> omapfb-fix-coding-style-remove-dead-line.patch
> omapfb-add-fb-manual-update-option-to-kconfig.patch
> omapfb-hwa742-fix-pointer-to-be-const.patch
>