2023-07-03 08:50:45

by Lee, Kah Jing

Subject: [PATCH v4] arm64: dts: agilex/stratix10: Updated QSPI Flash layout for UBIFS

From: Alif Zakuan Yuslaimi <[email protected]>

Non-UBIFS related boot and fpga data should be stored in qspi_boot (mtd0)
while keeping the rootfs with UBIFS in the root partition "mtd1".
Thus, update the QSPI flash layout to support UBIFS in the mtd root
partition.

Signed-off-by: Alif Zakuan Yuslaimi <[email protected]>
Signed-off-by: Kah Jing Lee <[email protected]>
---
V4->V3: Drop cover letter & remove unnecessary marker line
V3->V2: Update commit messages
V2->V1: Update subject prefix

arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 38ae674f2f02..12b960b9183c 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -202,12 +202,12 @@ partitions {

qspi_boot: partition@0 {
label = "Boot and fpga data";
- reg = <0x0 0x03FE0000>;
+ reg = <0x0 0x04200000>;
};

- qspi_rootfs: partition@3FE0000 {
- label = "Root Filesystem - JFFS2";
- reg = <0x03FE0000 0x0C020000>;
+ root: partition@4200000 {
+ label = "Root Filesystem - UBIFS";
+ reg = <0x04200000 0x0BE00000>;
};
};
};
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
index 07c3f8876613..608017e6e36a 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
@@ -128,12 +128,12 @@ partitions {

qspi_boot: partition@0 {
label = "Boot and fpga data";
- reg = <0x0 0x03FE0000>;
+ reg = <0x0 0x04200000>;
};

- qspi_rootfs: partition@3FE0000 {
- label = "Root Filesystem - JFFS2";
- reg = <0x03FE0000 0x0C020000>;
+ root: partition@4200000 {
+ label = "Root Filesystem - UBIFS";
+ reg = <0x04200000 0x0BE00000>;
};
};
};

base-commit: dad9774deaf1cf8e8f7483310dfb2690310193d2
--
2.25.1

2023-07-03 09:18:34

by Conor Dooley

Subject: Re: [PATCH v4] arm64: dts: agilex/stratix10: Updated QSPI Flash layout for UBIFS

On 03/07/2023 10:00, Markus Elfring wrote:

> …
>> ---
>> V4->V3: Drop cover letter & remove unnecessary marker line
>> V3->V2: Update commit messages
> …
>
> * Do you find the arrow notation helpful for the version identification?
>
> * How do you think about to avoid duplicate data in the version history?
>
> * Would an other listing style become nicer for the “patch changelog”?

This is a complete waste of contributor time. Please stop.

2023-07-03 12:29:19

by Krzysztof Kozlowski

Subject: Re: [PATCH v4] arm64: dts: agilex/stratix10: Updated QSPI Flash layout for UBIFS

On 03/07/2023 11:08, [email protected] wrote:
> On 03/07/2023 10:00, Markus Elfring wrote:
>
>> …
>>> ---
>>> V4->V3: Drop cover letter & remove unnecessary marker line
>>> V3->V2: Update commit messages
>> …
>>
>> * Do you find the arrow notation helpful for the version identification?
>>
>> * How do you think about to avoid duplicate data in the version history?
>>
>> * Would an other listing style become nicer for the “patch changelog”?
>
> This is a complete waste of contributor time. Please stop.

Markus is banned from the LKML. Just ignore the comments.

Best regards,
Krzysztof

2023-07-10 02:47:04

by Dinh Nguyen

Subject: Re: [PATCH v4] arm64: dts: agilex/stratix10: Updated QSPI Flash layout for UBIFS

On 7/3/23 03:36, [email protected] wrote:
> From: Alif Zakuan Yuslaimi <[email protected]>
>
> Non-UBIFS related boot and fpga data should be stored in qspi_boot (mtd0)
> while keeping the rootfs with UBIFS in the root partition "mtd1".
> Thus, update the QSPI flash layout to support UBIFS in the mtd root
> partition.
>
> Signed-off-by: Alif Zakuan Yuslaimi <[email protected]>
> Signed-off-by: Kah Jing Lee <[email protected]>
> ---
> V4->V3: Drop cover letter & remove unnecessary marker line
> V3->V2: Update commit messages
> V2->V1: Update subject prefix
>
> arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
> arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 38ae674f2f02..12b960b9183c 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -202,12 +202,12 @@ partitions {
>
> qspi_boot: partition@0 {
> label = "Boot and fpga data";
> - reg = <0x0 0x03FE0000>;
> + reg = <0x0 0x04200000>;
> };
>
> - qspi_rootfs: partition@3FE0000 {
> - label = "Root Filesystem - JFFS2";
> - reg = <0x03FE0000 0x0C020000>;
> + root: partition@4200000 {
> + label = "Root Filesystem - UBIFS";
> + reg = <0x04200000 0x0BE00000>;
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> index 07c3f8876613..608017e6e36a 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> @@ -128,12 +128,12 @@ partitions {
>
> qspi_boot: partition@0 {
> label = "Boot and fpga data";
> - reg = <0x0 0x03FE0000>;
> + reg = <0x0 0x04200000>;
> };
>
> - qspi_rootfs: partition@3FE0000 {
> - label = "Root Filesystem - JFFS2";
> - reg = <0x03FE0000 0x0C020000>;
> + root: partition@4200000 {
> + label = "Root Filesystem - UBIFS";
> + reg = <0x04200000 0x0BE00000>;
> };
> };
> };
>
> base-commit: dad9774deaf1cf8e8f7483310dfb2690310193d2

Applied!

Thanks,
Dinh