2023-09-14 08:46:05

by Yuan Tan

[permalink] [raw]
Subject: [PATCH v3 3/3] MIPS: Simplify malta_defconfig

Simplify malta_defconfig with POWER_RESET dependences.

Regenerate malta_defconfig with 'make savedefconfig'.

Suggested-by: Philippe Mathieu-Daudé <[email protected]>
Suggested-by: Christophe Leroy <[email protected]>
Signed-off-by: Yuan Tan <[email protected]>
---
arch/mips/configs/malta_defconfig | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/mips/configs/malta_defconfig b/arch/mips/configs/malta_defconfig
index 7ae07d57b79a..99049e993192 100644
--- a/arch/mips/configs/malta_defconfig
+++ b/arch/mips/configs/malta_defconfig
@@ -192,7 +192,6 @@ CONFIG_CFG80211=m
CONFIG_MAC80211=m
CONFIG_MAC80211_MESH=y
CONFIG_RFKILL=m
-CONFIG_PCI=y
CONFIG_DEVTMPFS=y
CONFIG_CONNECTOR=m
CONFIG_MTD=y
@@ -284,7 +283,6 @@ CONFIG_MOUSE_PS2_ELANTECH=y
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_CONSOLE=y
CONFIG_POWER_RESET=y
-CONFIG_POWER_RESET_PIIX4_POWEROFF=y
CONFIG_POWER_RESET_SYSCON=y
# CONFIG_HWMON is not set
CONFIG_FB=y
--
2.34.1


2023-09-15 15:10:42

by Philippe Mathieu-Daudé

[permalink] [raw]
Subject: Re: [PATCH v3 3/3] MIPS: Simplify malta_defconfig

On 14/9/23 10:44, Yuan Tan wrote:
> Simplify malta_defconfig with POWER_RESET dependences.
>
> Regenerate malta_defconfig with 'make savedefconfig'.
>
> Suggested-by: Philippe Mathieu-Daudé <[email protected]>
> Suggested-by: Christophe Leroy <[email protected]>
> Signed-off-by: Yuan Tan <[email protected]>
> ---
> arch/mips/configs/malta_defconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/configs/malta_defconfig b/arch/mips/configs/malta_defconfig
> index 7ae07d57b79a..99049e993192 100644
> --- a/arch/mips/configs/malta_defconfig
> +++ b/arch/mips/configs/malta_defconfig
> @@ -192,7 +192,6 @@ CONFIG_CFG80211=m
> CONFIG_MAC80211=m
> CONFIG_MAC80211_MESH=y
> CONFIG_RFKILL=m
> -CONFIG_PCI=y
> CONFIG_DEVTMPFS=y
> CONFIG_CONNECTOR=m
> CONFIG_MTD=y
> @@ -284,7 +283,6 @@ CONFIG_MOUSE_PS2_ELANTECH=y
> CONFIG_SERIAL_8250=y
> CONFIG_SERIAL_8250_CONSOLE=y
> CONFIG_POWER_RESET=y
> -CONFIG_POWER_RESET_PIIX4_POWEROFF=y
> CONFIG_POWER_RESET_SYSCON=y
> # CONFIG_HWMON is not set
> CONFIG_FB=y

IMHO this should be squashed with the previous patch,
to keep it "atomic", easing reverts or cherry-picks
during backports.

2023-09-15 22:15:36

by Yuan Tan

[permalink] [raw]
Subject: Re: [PATCH v3 3/3] MIPS: Simplify malta_defconfig


On 9/15/2023 9:35 PM, Philippe Mathieu-Daudé wrote:
> IMHO this should be squashed with the previous patch,
> to keep it "atomic", easing reverts or cherry-picks
> during backports.
Oh I will send v4 to squash these two patches :)