2023-01-23 18:42:13

by Rafael J. Wysocki

[permalink] [raw]
Subject: [PATCH v7 0/3] thermal: intel: Use generic trip points in 2 drivers

Hi All,

This is a new version of the series from Daniel posted as:

https://lore.kernel.org/linux-pm/[email protected]/

The first patch has been reworked (see https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
and the other two have been rebased on top of it.

I have retained the R-by tags from Rui, because the changes in patches [2-3/3] are
not essential, but I think that this new set needs to be tested again.

Srinivas, can you test it please?

Thanks!







2023-01-23 18:45:39

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH v7 0/3] thermal: intel: Use generic trip points in 2 drivers

On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki wrote:
> Hi All,
>
> This is a new version of the series from Daniel posted as:
>
> https://lore.kernel.org/linux-pm/[email protected]/
>
> The first patch has been reworked (see https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
> and the other two have been rebased on top of it.
>
> I have retained the R-by tags from Rui, because the changes in patches [2-3/3] are
> not essential, but I think that this new set needs to be tested again.
>
> Srinivas, can you test it please?

Something's wrong, sorry.

I get some invalid trip temperatures with this set.





2023-01-23 18:53:03

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH v7 0/3] thermal: intel: Use generic trip points in 2 drivers

On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki wrote:
> On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki wrote:
> > Hi All,
> >
> > This is a new version of the series from Daniel posted as:
> >
> > https://lore.kernel.org/linux-pm/[email protected]/
> >
> > The first patch has been reworked (see https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
> > and the other two have been rebased on top of it.
> >
> > I have retained the R-by tags from Rui, because the changes in patches [2-3/3] are
> > not essential, but I think that this new set needs to be tested again.
> >
> > Srinivas, can you test it please?
>
> Something's wrong, sorry.
>
> I get some invalid trip temperatures with this set.

Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID showing up in
sysfs, but it did show up before too.

Please test!




2023-01-23 19:26:22

by srinivas pandruvada

[permalink] [raw]
Subject: Re: [PATCH v7 0/3] thermal: intel: Use generic trip points in 2 drivers

On Mon, 2023-01-23 at 19:52 +0100, Rafael J. Wysocki wrote:
> On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki wrote:
> > On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki wrote:
> > > Hi All,
> > >
> > > This is a new version of the series from Daniel posted as:
> > >
> > > https://lore.kernel.org/linux-pm/[email protected]/
> > >
> > > The first patch has been reworked (see
> > > https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
> > > and the other two have been rebased on top of it.
> > >
> > > I have retained the R-by tags from Rui, because the changes in
> > > patches [2-3/3] are
> > > not essential, but I think that this new set needs to be tested
> > > again.
> > >
> > > Srinivas, can you test it please?
> >
> > Something's wrong, sorry.
> >
> > I get some invalid trip temperatures with this set.
>
> Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID showing
> up in
> sysfs, but it did show up before too.
>
> Please test!
>

>

>
> It will be easy if you have some test branch to avoid dependecies on
> other patches.

Thanks,
Srinivas

>
>


2023-01-23 19:54:36

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH v7 0/3] thermal: intel: Use generic trip points in 2 drivers

On Mon, Jan 23, 2023 at 8:26 PM srinivas pandruvada
<[email protected]> wrote:
>
> On Mon, 2023-01-23 at 19:52 +0100, Rafael J. Wysocki wrote:
> > On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki wrote:
> > > On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki wrote:
> > > > Hi All,
> > > >
> > > > This is a new version of the series from Daniel posted as:
> > > >
> > > > https://lore.kernel.org/linux-pm/[email protected]/
> > > >
> > > > The first patch has been reworked (see
> > > > https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/)
> > > > and the other two have been rebased on top of it.
> > > >
> > > > I have retained the R-by tags from Rui, because the changes in
> > > > patches [2-3/3] are
> > > > not essential, but I think that this new set needs to be tested
> > > > again.
> > > >
> > > > Srinivas, can you test it please?
> > >
> > > Something's wrong, sorry.
> > >
> > > I get some invalid trip temperatures with this set.
> >
> > Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID showing
> > up in
> > sysfs, but it did show up before too.
> >
> > Please test!
> >
>
> >
>
> >
> It will be easy if you have some test branch to avoid dependecies on
> other patches.

Please see the thermal-intel-test branch in linux-pm.git. It's this
series on top of the core thermal stuff + ARM drivers.

2023-01-23 21:35:45

by srinivas pandruvada

[permalink] [raw]
Subject: Re: [PATCH v7 0/3] thermal: intel: Use generic trip points in 2 drivers

On Mon, 2023-01-23 at 20:54 +0100, Rafael J. Wysocki wrote:
> On Mon, Jan 23, 2023 at 8:26 PM srinivas pandruvada
> <[email protected]> wrote:
> >
> > On Mon, 2023-01-23 at 19:52 +0100, Rafael J. Wysocki wrote:
> > > On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki
> > > wrote:
> > > > On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki
> > > > wrote:
> > > > > Hi All,
> > > > >
> > > > > This is a new version of the series from Daniel posted as:
> > > > >
> > > > > https://lore.kernel.org/linux-pm/[email protected]/
> > > > >
> > > > > The first patch has been reworked (see
> > > > > https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/
> > > > > )
> > > > > and the other two have been rebased on top of it.
> > > > >
> > > > > I have retained the R-by tags from Rui, because the changes
> > > > > in
> > > > > patches [2-3/3] are
> > > > > not essential, but I think that this new set needs to be
> > > > > tested
> > > > > again.
> > > > >
> > > > > Srinivas, can you test it please?
> > > >
> > > > Something's wrong, sorry.
> > > >
> > > > I get some invalid trip temperatures with this set.
> > >
> > > Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID
> > > showing
> > > up in
> > > sysfs, but it did show up before too.
> > >
> > > Please test!
> > >
> >
> > >
> >
> > >
> > It will be easy if you have some test branch to avoid dependecies
> > on
> > other patches.
>
> Please see the thermal-intel-test branch in linux-pm.git.  It's this
> series on top of the core thermal stuff + ARM drivers.
Tested on one system. Works fine.

Thanks,
Srinivas


2023-01-24 14:52:34

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH v7 0/3] thermal: intel: Use generic trip points in 2 drivers

On Mon, Jan 23, 2023 at 10:35 PM srinivas pandruvada
<[email protected]> wrote:
>
> On Mon, 2023-01-23 at 20:54 +0100, Rafael J. Wysocki wrote:
> > On Mon, Jan 23, 2023 at 8:26 PM srinivas pandruvada
> > <[email protected]> wrote:
> > >
> > > On Mon, 2023-01-23 at 19:52 +0100, Rafael J. Wysocki wrote:
> > > > On Monday, January 23, 2023 7:45:30 PM CET Rafael J. Wysocki
> > > > wrote:
> > > > > On Monday, January 23, 2023 7:36:52 PM CET Rafael J. Wysocki
> > > > > wrote:
> > > > > > Hi All,
> > > > > >
> > > > > > This is a new version of the series from Daniel posted as:
> > > > > >
> > > > > > https://lore.kernel.org/linux-pm/[email protected]/
> > > > > >
> > > > > > The first patch has been reworked (see
> > > > > > https://lore.kernel.org/linux-pm/5911499.lOV4Wx5bFT@kreacher/
> > > > > > )
> > > > > > and the other two have been rebased on top of it.
> > > > > >
> > > > > > I have retained the R-by tags from Rui, because the changes
> > > > > > in
> > > > > > patches [2-3/3] are
> > > > > > not essential, but I think that this new set needs to be
> > > > > > tested
> > > > > > again.
> > > > > >
> > > > > > Srinivas, can you test it please?
> > > > >
> > > > > Something's wrong, sorry.
> > > > >
> > > > > I get some invalid trip temperatures with this set.
> > > >
> > > > Sorry, scratch this, I got confused by THERMAL_TEMP_INVALID
> > > > showing
> > > > up in
> > > > sysfs, but it did show up before too.
> > > >
> > > > Please test!
> > > >
> > >
> > > >
> > >
> > > >
> > > It will be easy if you have some test branch to avoid dependecies
> > > on
> > > other patches.
> >
> > Please see the thermal-intel-test branch in linux-pm.git. It's this
> > series on top of the core thermal stuff + ARM drivers.
> Tested on one system. Works fine.

Thanks!

I'll add a T-by from you to the series (which will be moved to the
thermal-intel branch).