2017-08-22 10:18:52

by Chao Fan

Subject: [PATCH] actbl1.h: use tab instead of seven spaces as the indentation

The indentation of these two lines is seven spaces, but not tab.
So fix it.

Signed-off-by: Chao Fan <[email protected]>
---
include/acpi/actbl1.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index b4ce55c008b0..d13e5b416a7e 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -1223,9 +1223,9 @@ struct acpi_srat_mem_affinity {
u16 reserved; /* Reserved, must be zero */
u64 base_address;
u64 length;
- u32 reserved1;
+ u32 reserved1;
u32 flags;
- u64 reserved2; /* Reserved, must be zero */
+ u64 reserved2; /* Reserved, must be zero */
};

/* Flags */
--
2.13.5

2017-08-23 03:43:40

by Zheng, Lv

Subject: RE: [PATCH] actbl1.h: use tab instead of seven spaces as the indentation

Hi,

> From: [email protected] [mailto:[email protected]] On Behalf Of Chao Fan
> Subject: [PATCH] actbl1.h: use tab instead of seven spaces as the indentation
>
> The indentation of these two lines is seven spaces, but not tab.
> So fix it.
>
> Signed-off-by: Chao Fan <[email protected]>
> ---
> include/acpi/actbl1.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index b4ce55c008b0..d13e5b416a7e 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -1223,9 +1223,9 @@ struct acpi_srat_mem_affinity {
> u16 reserved; /* Reserved, must be zero */
> u64 base_address;
> u64 length;
> - u32 reserved1;
> + u32 reserved1;
> u32 flags;
> - u64 reserved2; /* Reserved, must be zero */
> + u64 reserved2; /* Reserved, must be zero */
> };
>
> /* Flags */
> --

You needn't do this manually.
An indentation fix commit can be easily and automatically generated by ACPICA linuxize script - divergence.sh.
See Documentation/acpi/linuxized-acpica.txt for detailed information.

Thanks
Lv

2017-08-23 03:51:04

by Chao Fan

Subject: Re: [PATCH] actbl1.h: use tab instead of seven spaces as the indentation

On Wed, Aug 23, 2017 at 03:43:33AM +0000, Zheng, Lv wrote:
>Hi,
>
>> From: [email protected] [mailto:[email protected]] On Behalf Of Chao Fan
>> Subject: [PATCH] actbl1.h: use tab instead of seven spaces as the indentation
>>
>> The indentation of these two lines is seven spaces, but not tab.
>> So fix it.
>>
>> Signed-off-by: Chao Fan <[email protected]>
>> ---
>> include/acpi/actbl1.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
>> index b4ce55c008b0..d13e5b416a7e 100644
>> --- a/include/acpi/actbl1.h
>> +++ b/include/acpi/actbl1.h
>> @@ -1223,9 +1223,9 @@ struct acpi_srat_mem_affinity {
>> u16 reserved; /* Reserved, must be zero */
>> u64 base_address;
>> u64 length;
>> - u32 reserved1;
>> + u32 reserved1;
>> u32 flags;
>> - u64 reserved2; /* Reserved, must be zero */
>> + u64 reserved2; /* Reserved, must be zero */
>> };
>>
>> /* Flags */
>> --
>
Hi Lv,

Thank you for your reply.

>You needn't do this manually.

OK, I got it.

>An indentation fix commit can be easily and automatically generated by ACPICA linuxize script - divergence.sh.
>See Documentation/acpi/linuxized-acpica.txt for detailed information.

I will see that.

Thanks,
Chao Fan

>
>Thanks
>Lv
>
>