Hi Linus,
After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
set_irq_flags(irq, IRQF_VALID);
^
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
set_irq_flags(irq, IRQF_VALID);
^
Caused by commit
8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
set_irq_flags was removed before v4.3-rc2 ...
I have used the gpio tree from next-20151215 for today.
--
Cheers,
Stephen Rothwell [email protected]
Hi Stephen,
Sorry. It's my mistake. In the first patch set, I tested it with "irq_clear_status_flags(irq, IRQ_NOREQUEST);" and in the v2 patch set the old one got in.
Regards
Dhananjay
-----Original Message-----
From: Stephen Rothwell [mailto:[email protected]]
Sent: Wednesday, December 16, 2015 9:08 AM
To: Linus Walleij
Cc: [email protected]; [email protected]; Yendapally Reddy Dhananjaya Reddy
Subject: linux-next: build failure after merge of the gpio tree
Hi Linus,
After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
set_irq_flags(irq, IRQF_VALID);
^
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
set_irq_flags(irq, IRQF_VALID);
^
Caused by commit
8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
set_irq_flags was removed before v4.3-rc2 ...
I have used the gpio tree from next-20151215 for today.
--
Cheers,
Stephen Rothwell [email protected]
Hi Linus,
On Wed, 16 Dec 2015 14:37:55 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
> set_irq_flags(irq, IRQF_VALID);
> ^
> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
> set_irq_flags(irq, IRQF_VALID);
> ^
>
> Caused by commit
>
> 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
>
> set_irq_flags was removed before v4.3-rc2 ...
>
> I have used the gpio tree from next-20151215 for today.
I am still getting this error.
--
Cheers,
Stephen Rothwell [email protected]
On Mon, Dec 21, 2015 at 6:02 AM, Stephen Rothwell <[email protected]> wrote:
> Hi Linus,
>
> On Wed, 16 Dec 2015 14:37:55 +1100 Stephen Rothwell <[email protected]> wrote:
>>
>> After merging the gpio tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
>> set_irq_flags(irq, IRQF_VALID);
>> ^
>> drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
>> set_irq_flags(irq, IRQF_VALID);
>> ^
>>
>> Caused by commit
>>
>> 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
>>
>> set_irq_flags was removed before v4.3-rc2 ...
>>
>> I have used the gpio tree from next-20151215 for today.
>
> I am still getting this error.
Yeah I was applying the fix to the pin control tree, never fix stuff late on
fridays... will apply the patch to the GPIO tree as well, I see no better
solution.
Yours,
Linus Walleij