2010-08-05 20:29:50

by Julia Lawall

Subject: [PATCH 34/42] drivers/message/fusion: Adjust confusing if indentation

From: Julia Lawall <[email protected]>

Indent the branch of an if.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>

---
drivers/message/fusion/mptbase.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index d8c668d..92e4b25 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -8049,7 +8049,7 @@ union loginfo_type {
code_desc = ir_code_str[sas_loginfo.dw.code];
if (sas_loginfo.dw.subcode >=
ARRAY_SIZE(raid_sub_code_str))
- break;
+ break;
if (sas_loginfo.dw.code == 0)
sub_code_desc =
raid_sub_code_str[sas_loginfo.dw.subcode];

2010-08-09 14:22:21

by Desai, Kashyap

Subject: RE: [PATCH 34/42] drivers/message/fusion: Adjust confusing if indentation

> -----Original Message-----
> From: Julia Lawall [mailto:[email protected]]
> Sent: Friday, August 06, 2010 1:57 AM
> To: Moore, Eric; Support, Software; DL-MPT Fusion Linux; linux-
> [email protected]; [email protected]; kernel-
> [email protected]
> Subject: [PATCH 34/42] drivers/message/fusion: Adjust confusing if
> indentation
>
> From: Julia Lawall <[email protected]>
>
> Indent the branch of an if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column == p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
> drivers/message/fusion/mptbase.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/message/fusion/mptbase.c
> b/drivers/message/fusion/mptbase.c
> index d8c668d..92e4b25 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -8049,7 +8049,7 @@ union loginfo_type {
> code_desc = ir_code_str[sas_loginfo.dw.code];
> if (sas_loginfo.dw.subcode >=
> ARRAY_SIZE(raid_sub_code_str))
> - break;
> + break;
Agree. Please consider this patch as an ACKed.
Thanks, Kashyap
> if (sas_loginfo.dw.code == 0)
> sub_code_desc =
> raid_sub_code_str[sas_loginfo.dw.subcode];