2007-08-13 11:54:25

by Joe Perches

[permalink] [raw]
Subject: [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

Add file pattern to MAINTAINER entry

Signed-off-by: Joe Perches <[email protected]>

diff --git a/MAINTAINERS b/MAINTAINERS
index 3e962b1..25bc39a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5046,6 +5046,10 @@ L: [email protected]
W: http://linuxtv.org
T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
S: Maintained
+F: Documentation/video4linux/
+F: drivers/media/
+F: include/linux/videodev2.h
+F: include/media/

VT1211 HARDWARE MONITOR DRIVER
P: Juerg Haefliger


2007-08-13 18:39:14

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX


Em Dom, 2007-08-12 às 23:39 -0700, [email protected] escreveu:
> Add file pattern to MAINTAINER entry

> @@ -5046,6 +5046,10 @@ L: [email protected]
> +F: Documentation/video4linux/
> +F: drivers/media/
> +F: include/linux/videodev2.h
> +F: include/media/

There are more include files to be added, for the older V4L APIs:
F: include/linux/video_decoder.h
F: include/linux/videodev.h

Cheers,
Mauro

2007-08-13 18:47:28

by Hans Verkuil

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

On Monday 13 August 2007 08:39:28 [email protected] wrote:
> Add file pattern to MAINTAINER entry
>
> Signed-off-by: Joe Perches <[email protected]>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3e962b1..25bc39a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5046,6 +5046,10 @@ L: [email protected]
> W: http://linuxtv.org
> T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
> S: Maintained
> +F: Documentation/video4linux/
> +F: drivers/media/
> +F: include/linux/videodev2.h
> +F: include/media/
>
> VT1211 HARDWARE MONITOR DRIVER
> P: Juerg Haefliger
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> [email protected]
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer

While we're at it: I noticed that there was no entry for the ivtv driver
(part of the kernel since 2.6.22). So here it is:

Signed-off-by: Hans Verkuil <[email protected]>

Regards,

Hans

--- MAINTAINERS.org 2007-08-13 20:23:47.000000000 +0200
+++ MAINTAINERS 2007-08-13 20:28:17.000000000 +0200
@@ -2036,6 +2036,17 @@
W: http://www.melware.de
S: Maintained

+IVTV VIDEO4LINUX DRIVER
+P: Hans Verkuil
+M: [email protected]
+L: [email protected]
+L: [email protected]
+L: [email protected]
+W: http://www.ivtvdriver.org
+S: Maintained
+F: Documentation/video4linux/README.ivtv
+F: drivers/media/video/ivtv/
+
JOURNALLING FLASH FILE SYSTEM V2 (JFFS2)
P: David Woodhouse
M: [email protected]

2007-08-13 18:50:49

by Joe Perches

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

On Mon, 2007-08-13 at 15:15 -0300, Mauro Carvalho Chehab wrote:
> There are more include files to be added, for the older V4L APIs:
> F: include/linux/video_decoder.h
> F: include/linux/videodev.h

VIDEO FOR LINUX
P: Mauro Carvalho Chehab
M: [email protected]
M: [email protected]
L: [email protected]
W: http://linuxtv.org
T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
S: Maintained
F: Documentation/video4linux/
F: drivers/media/
F: include/linux/video_decoder.h
F include/linux/videodev.h
F: include/linux/videodev2.h
F: include/media/


2007-08-13 19:05:11

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX


Em Seg, 2007-08-13 às 11:33 -0700, Joe Perches escreveu:
> On Mon, 2007-08-13 at 15:15 -0300, Mauro Carvalho Chehab wrote:
> > There are more include files to be added, for the older V4L APIs:
> > F: include/linux/video_decoder.h
> > F: include/linux/videodev.h
>
> VIDEO FOR LINUX
> P: Mauro Carvalho Chehab
> M: [email protected]
> M: [email protected]
> L: [email protected]
> W: http://linuxtv.org
> T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
> S: Maintained
> F: Documentation/video4linux/
> F: drivers/media/
> F: include/linux/video_decoder.h
> F include/linux/videodev.h
> F: include/linux/videodev2.h
> F: include/media/

Acked-by: Mauro Carvalho Chehab <[email protected]>
>
>
--
Cheers,
Mauro

2007-08-13 19:24:22

by Manu Abraham

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

On 8/13/07, Joe Perches <[email protected]> wrote:
> On Mon, 2007-08-13 at 15:15 -0300, Mauro Carvalho Chehab wrote:
> > There are more include files to be added, for the older V4L APIs:
> > F: include/linux/video_decoder.h
> > F: include/linux/videodev.h
>
> VIDEO FOR LINUX
> P: Mauro Carvalho Chehab
> M: [email protected]
> M: [email protected]
> L: [email protected]
> W: http://linuxtv.org
> T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
> S: Maintained
> F: Documentation/video4linux/


> F: drivers/media/

This means everything under media is maintained under V4L. Incorrect

2007-08-13 21:38:05

by Joe Perches

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

On Mon, 2007-08-13 at 20:32 +0200, Hans Verkuil wrote:
> --- MAINTAINERS.org 2007-08-13 20:23:47.000000000 +0200
> +++ MAINTAINERS 2007-08-13 20:28:17.000000000 +0200
> +IVTV VIDEO4LINUX DRIVER
> +P: Hans Verkuil
> +M: [email protected]
> +L: [email protected]
> +L: [email protected]
> +L: [email protected]
> +W: http://www.ivtvdriver.org
> +S: Maintained
> +F: Documentation/video4linux/README.ivtv
> +F: drivers/media/video/ivtv/

Added locally.

2007-08-14 02:00:42

by Joe Perches

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

On Mon, 2007-08-13 at 23:22 +0400, Manu Abraham wrote:
> > F: drivers/media/
> This means everything under media is maintained under V4L. Incorrect

What would you like?

2007-08-14 02:08:34

by Michael Ira Krufky

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

Joe Perches wrote:
> On Mon, 2007-08-13 at 23:22 +0400, Manu Abraham wrote:
>
>>> F: drivers/media/
>>>
>> This means everything under media is maintained under V4L. Incorrect
>>
>
> What would you like?
>
>
Just dont list "drivers/media".

Instead:

drivers/media/video -- v4l
drivers/media/radio -- v4l


drivers/media/dvb -- dvb

Cheers,

Michael Krufky

2007-08-14 02:21:17

by Manu Abraham

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

On 8/14/07, Joe Perches <[email protected]> wrote:
> On Mon, 2007-08-13 at 23:22 +0400, Manu Abraham wrote:
> > > F: drivers/media/
> > This means everything under media is maintained under V4L. Incorrect
>
> What would you like?
>

media/video
and
media/radio

*only* belong under V4L

Manu

2007-08-14 02:45:41

by Joe Perches

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

On Mon, 2007-08-13 at 22:08 -0400, Michael Krufky wrote:
> drivers/media/video -- v4l
> drivers/media/radio -- v4l
>
> drivers/media/dvb -- dvb

VIDEO FOR LINUX
P: Mauro Carvalho Chehab
M: [email protected]
P: LinuxTV.org Project
M: [email protected]
L: [email protected]
W: http://linuxtv.org
T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
S: Maintained
F: Documentation/video4linux/
F: drivers/media/video/
F: drivers/media/radio/
F: include/linux/video_decoder.h
F include/linux/videodev.h
F: include/linux/videodev2.h
F: include/media/

DVB SUBSYSTEM AND DRIVERS
P: LinuxTV.org Project
M: [email protected]
L: [email protected] (subscribers-only)
W: http://linuxtv.org/
T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
S: Maintained
F: Documentation/dvb/
F: drivers/media/dvb/
F: drivers/media/common/saa7146*.c
F: include/linux/dvb/


2007-08-14 13:27:42

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX


Em Seg, 2007-08-13 às 19:44 -0700, Joe Perches escreveu:
> On Mon, 2007-08-13 at 22:08 -0400, Michael Krufky wrote:
> > drivers/media/video -- v4l
> > drivers/media/radio -- v4l
> >
> > drivers/media/dvb -- dvb
>
> VIDEO FOR LINUX
> P: Mauro Carvalho Chehab
> M: [email protected]
> P: LinuxTV.org Project
> M: [email protected]
> L: [email protected]
> W: http://linuxtv.org
> T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
> S: Maintained
> F: Documentation/video4linux/
> F: drivers/media/video/
> F: drivers/media/radio/
> F: include/linux/video_decoder.h
> F include/linux/videodev.h
You missed ':'
> F: include/linux/videodev2.h
> F: include/media/

This is not ok. Some maintained files won't be hit. You should add also
something like:
F: drivers/media/*
F: drivers/media/common/ir-functions.c
F: drivers/media/common/ir-keymaps.c
F: drivers/media/common/Kconfig
F: drivers/media/common/Makefile

--
Cheers,
Mauro

2007-08-14 13:35:58

by Manu Abraham

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

On 8/14/07, Mauro Carvalho Chehab <[email protected]> wrote:
>
> Em Seg, 2007-08-13 ?s 19:44 -0700, Joe Perches escreveu:
> > On Mon, 2007-08-13 at 22:08 -0400, Michael Krufky wrote:
> > > drivers/media/video -- v4l
> > > drivers/media/radio -- v4l
> > >
> > > drivers/media/dvb -- dvb
> >
> > VIDEO FOR LINUX
> > P: Mauro Carvalho Chehab
> > M: [email protected]
> > P: LinuxTV.org Project
> > M: [email protected]
> > L: [email protected]
> > W: http://linuxtv.org
> > T: git kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
> > S: Maintained
> > F: Documentation/video4linux/
> > F: drivers/media/video/
> > F: drivers/media/radio/
> > F: include/linux/video_decoder.h
> > F include/linux/videodev.h
> You missed ':'
> > F: include/linux/videodev2.h
> > F: include/media/
>
> This is not ok. Some maintained files won't be hit. You should add also
> something like:


> F: drivers/media/*


This is NOT OK !

2007-08-14 13:48:19

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX


>
> > F: drivers/media/*
>
>
> This is NOT OK !

This IS ok. You just need to read the definition of the 'F' tag:

F: Files and directories with wildcard patterns.
A trailing slash includes all files and subdirectory files.
F: drivers/net/ all files in and below drivers/net
F: drivers/net/* all files in drivers/net, but not below
F: */net/* all files in "any top level directory"/net
One pattern per line. Multiple F: lines acceptable.

This tag just includes Kconfig and Makefile.

--
Cheers,
Mauro

2007-08-14 14:02:23

by Manu Abraham

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

On 8/14/07, Mauro Carvalho Chehab <[email protected]> wrote:
>
> >
> > > F: drivers/media/*
> >
> >
> > This is NOT OK !
>
> This IS ok. You just need to read the definition of the 'F' tag:
>
> F: Files and directories with wildcard patterns.
> A trailing slash includes all files and subdirectory files.
> F: drivers/net/ all files in and below drivers/net
> F: drivers/net/* all files in drivers/net, but not below
> F: */net/* all files in "any top level directory"/net
> One pattern per line. Multiple F: lines acceptable.
>
> This tag just includes Kconfig and Makefile.


Just as much as you state that, the reverse is as well true for
Kconfig and Makefile.

2007-08-15 00:31:29

by hermann pitton

[permalink] [raw]
Subject: Re: [v4l-dvb-maintainer] [PATCH] [534/2many] MAINTAINERS - VIDEO FOR LINUX

Am Dienstag, den 14.08.2007, 18:02 +0400 schrieb Manu Abraham:
> On 8/14/07, Mauro Carvalho Chehab <[email protected]> wrote:
> >
> > >
> > > > F: drivers/media/*
> > >
> > >
> > > This is NOT OK !
> >
> > This IS ok. You just need to read the definition of the 'F' tag:
> >
> > F: Files and directories with wildcard patterns.
> > A trailing slash includes all files and subdirectory files.
> > F: drivers/net/ all files in and below drivers/net
> > F: drivers/net/* all files in drivers/net, but not below
> > F: */net/* all files in "any top level directory"/net
> > One pattern per line. Multiple F: lines acceptable.
> >
> > This tag just includes Kconfig and Makefile.
>
>
> Just as much as you state that, the reverse is as well true for
> Kconfig and Makefile.
>

Please explain what you still want and why.

After two almost wasted years, you should be able to do so.