2022-11-18 23:15:02

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH 047/606] i2c: mux: pca9541: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/i2c/muxes/i2c-mux-pca9541.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
index ea83de78f52d..09d1d9e67e31 100644
--- a/drivers/i2c/muxes/i2c-mux-pca9541.c
+++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
@@ -283,8 +283,7 @@ static int pca9541_release_chan(struct i2c_mux_core *muxc, u32 chan)
/*
* I2C init/probing/exit functions
*/
-static int pca9541_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int pca9541_probe(struct i2c_client *client)
{
struct i2c_adapter *adap = client->adapter;
struct i2c_mux_core *muxc;
@@ -337,7 +336,7 @@ static struct i2c_driver pca9541_driver = {
.name = "pca9541",
.of_match_table = of_match_ptr(pca9541_of_match),
},
- .probe = pca9541_probe,
+ .probe_new = pca9541_probe,
.remove = pca9541_remove,
.id_table = pca9541_id,
};
--
2.38.1



2022-11-18 23:49:30

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 047/606] i2c: mux: pca9541: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:36:21PM +0100, Uwe Kleine-K?nig wrote:
> From: Uwe Kleine-K?nig <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/i2c/muxes/i2c-mux-pca9541.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
> index ea83de78f52d..09d1d9e67e31 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
> @@ -283,8 +283,7 @@ static int pca9541_release_chan(struct i2c_mux_core *muxc, u32 chan)
> /*
> * I2C init/probing/exit functions
> */
> -static int pca9541_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int pca9541_probe(struct i2c_client *client)
> {
> struct i2c_adapter *adap = client->adapter;
> struct i2c_mux_core *muxc;
> @@ -337,7 +336,7 @@ static struct i2c_driver pca9541_driver = {
> .name = "pca9541",
> .of_match_table = of_match_ptr(pca9541_of_match),
> },
> - .probe = pca9541_probe,
> + .probe_new = pca9541_probe,
> .remove = pca9541_remove,
> .id_table = pca9541_id,
> };
> --
> 2.38.1
>

2022-11-19 17:28:17

by Peter Rosin

[permalink] [raw]
Subject: Re: [PATCH 047/606] i2c: mux: pca9541: Convert to i2c's .probe_new()

2022-11-18 at 23:36, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Acked-by: Peter Rosin <[email protected]>

> ---
> drivers/i2c/muxes/i2c-mux-pca9541.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
> index ea83de78f52d..09d1d9e67e31 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
> @@ -283,8 +283,7 @@ static int pca9541_release_chan(struct i2c_mux_core *muxc, u32 chan)
> /*
> * I2C init/probing/exit functions
> */
> -static int pca9541_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int pca9541_probe(struct i2c_client *client)
> {
> struct i2c_adapter *adap = client->adapter;
> struct i2c_mux_core *muxc;
> @@ -337,7 +336,7 @@ static struct i2c_driver pca9541_driver = {
> .name = "pca9541",
> .of_match_table = of_match_ptr(pca9541_of_match),
> },
> - .probe = pca9541_probe,
> + .probe_new = pca9541_probe,
> .remove = pca9541_remove,
> .id_table = pca9541_id,
> };

2022-12-05 10:00:36

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 047/606] i2c: mux: pca9541: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:36:21PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Found an older patch doing the same, but still thanks!


Attachments:
(No filename) (374.00 B)
signature.asc (849.00 B)
Download all attachments

2022-12-05 16:25:57

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH 047/606] i2c: mux: pca9541: Convert to i2c's .probe_new()

On Mon, Dec 05, 2022 at 10:46:16AM +0100, Wolfram Sang wrote:
> On Fri, Nov 18, 2022 at 11:36:21PM +0100, Uwe Kleine-K?nig wrote:
> > From: Uwe Kleine-K?nig <[email protected]>
> >
> > The probe function doesn't make use of the i2c_device_id * parameter so it
> > can be trivially converted.
> >
> > Signed-off-by: Uwe Kleine-K?nig <[email protected]>
>
> Found an older patch doing the same, but still thanks!

Yeah, sorry for the duplicates. I started on mainline instead of next +
my patchstack when creating this series.

Thanks for picking these up
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (762.00 B)
signature.asc (499.00 B)
Download all attachments