2022-11-15 02:57:53

by Bernhard Rosenkränzer

[permalink] [raw]
Subject: [PATCH v2 03/15] dt-bindings: iio: adc: mediatek: add MT8365 SoC bindings

From: Fabien Parent <[email protected]>

Add binding for the ADC present in MT8365 SoC.

Signed-off-by: Fabien Parent <[email protected]>
---
.../devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml
index 7f79a06e76f59..ed582c6e7ea9c 100644
--- a/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml
@@ -38,6 +38,7 @@ properties:
- mediatek,mt8188-auxadc
- mediatek,mt8195-auxadc
- mediatek,mt8516-auxadc
+ - mediatek,mt8365-auxadc
- const: mediatek,mt8173-auxadc

reg:
--
2.38.1



Subject: Re: [PATCH v2 03/15] dt-bindings: iio: adc: mediatek: add MT8365 SoC bindings

Il 15/11/22 03:54, Bernhard Rosenkränzer ha scritto:
> From: Fabien Parent <[email protected]>
>
> Add binding for the ADC present in MT8365 SoC.
>
> Signed-off-by: Fabien Parent <[email protected]>

You're sending the patch, hence you have to add your signoff, which is missing.

Please add it.

Regards,
Angelo

2022-11-15 10:27:44

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 03/15] dt-bindings: iio: adc: mediatek: add MT8365 SoC bindings

On 15/11/2022 03:54, Bernhard Rosenkränzer wrote:
> From: Fabien Parent <[email protected]>
>
> Add binding for the ADC present in MT8365 SoC.
>
> Signed-off-by: Fabien Parent <[email protected]>


Drop second, redundant "bindings" from subject.

> ---
> .../devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml
> index 7f79a06e76f59..ed582c6e7ea9c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt2701-auxadc.yaml
> @@ -38,6 +38,7 @@ properties:
> - mediatek,mt8188-auxadc
> - mediatek,mt8195-auxadc
> - mediatek,mt8516-auxadc
> + - mediatek,mt8365-auxadc

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.


Best regards,
Krzysztof