2020-04-29 10:26:46

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH] brcmfmac: no need to check return value of debugfs_create functions

On 4/29/2020 12:15 PM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> In doing this, make brcmf_debugfs_add_entry() return void as no one was
> even paying attention to the return value.
>
> Cc: Arend van Spriel <[email protected]>
> Cc: Franky Lin <[email protected]>
> Cc: Hante Meuleman <[email protected]>
> Cc: Chi-Hsien Lin <[email protected]>
> Cc: Wright Feng <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Pieter-Paul Giesberts <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: "Rafał Miłecki" <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> .../net/wireless/broadcom/brcm80211/brcmfmac/debug.c | 9 +++------
> .../net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 12 +++++-------
> 2 files changed, 8 insertions(+), 13 deletions(-)