2023-05-05 06:31:15

by Jiapeng Chong

Subject: [PATCH] soc: mediatek: mtk-mutex: Remove unnecessary .owner

Remove .owner field if calls are used which set it automatically.

./drivers/soc/mediatek/mtk-mutex.c:1054:3-8: No need to set .owner here. The core will do it.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4869
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/soc/mediatek/mtk-mutex.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
index 26f3d9a41496..4aa0913817ae 100644
--- a/drivers/soc/mediatek/mtk-mutex.c
+++ b/drivers/soc/mediatek/mtk-mutex.c
@@ -1051,7 +1051,6 @@ static struct platform_driver mtk_mutex_driver = {
.probe = mtk_mutex_probe,
.driver = {
.name = "mediatek-mutex",
- .owner = THIS_MODULE,
.of_match_table = mutex_driver_dt_match,
},
};
--
2.20.1.7.g153144c

2023-05-29 15:36:22

by Matthias Brugger

Subject: Re: [PATCH] soc: mediatek: mtk-mutex: Remove unnecessary .owner

On 05/05/2023 08:19, Jiapeng Chong wrote:
> Remove .owner field if calls are used which set it automatically.
>
> ./drivers/soc/mediatek/mtk-mutex.c:1054:3-8: No need to set .owner here. The core will do it.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4869
> Signed-off-by: Jiapeng Chong <[email protected]>

Applied, thanks!

> ---
> drivers/soc/mediatek/mtk-mutex.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
> index 26f3d9a41496..4aa0913817ae 100644
> --- a/drivers/soc/mediatek/mtk-mutex.c
> +++ b/drivers/soc/mediatek/mtk-mutex.c
> @@ -1051,7 +1051,6 @@ static struct platform_driver mtk_mutex_driver = {
> .probe = mtk_mutex_probe,
> .driver = {
> .name = "mediatek-mutex",
> - .owner = THIS_MODULE,
> .of_match_table = mutex_driver_dt_match,
> },
> };