2020-06-28 09:34:51

by Geliang Tang

Subject: [PATCH net-next] sctp: use list_is_singular in sctp_list_single_entry

Use list_is_singular() instead of open-coding.

Signed-off-by: Geliang Tang <[email protected]>
---
include/net/sctp/sctp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h
index f8bcb75bb044..e3bd198b00ae 100644
--- a/include/net/sctp/sctp.h
+++ b/include/net/sctp/sctp.h
@@ -412,7 +412,7 @@ static inline void sctp_skb_set_owner_r(struct sk_buff *skb, struct sock *sk)
/* Tests if the list has one and only one entry. */
static inline int sctp_list_single_entry(struct list_head *head)
{
- return (head->next != head) && (head->next == head->prev);
+ return list_is_singular(head);
}

static inline bool sctp_chunk_pending(const struct sctp_chunk *chunk)
--
2.17.1

2020-06-29 20:50:12

by David Miller

Subject: Re: [PATCH net-next] sctp: use list_is_singular in sctp_list_single_entry

From: Geliang Tang <[email protected]>
Date: Sun, 28 Jun 2020 17:32:25 +0800

> Use list_is_singular() instead of open-coding.
>
> Signed-off-by: Geliang Tang <[email protected]>

Applied, thanks.